Bug 167512

Summary: Fix diagnostic logging under loader/
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, dbates, japhet
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2017-01-27 10:14:50 PST 
Fix diagnostic logging under loader/. We should not be using logDiagnosticLoggingWithValue() without a numeric value.
Comment 1 Chris Dumez 2017-01-27 10:16:44 PST 
Created attachment 299941 [details]
Patch
Comment 2 Alex Christensen 2017-01-27 12:01:50 PST 
Comment on attachment 299941 [details]
Patch

Seriously, make logDiagnosticMessageWithValue take a double
Comment 3 Chris Dumez 2017-01-27 12:11:14 PST 
(In reply to comment #2)
> Comment on attachment 299941 [details]
> Patch
> 
> Seriously, make logDiagnosticMessageWithValue take a double

Yes. I am *first* fixing all the call sites that do not pass a number, *then* I'll fix the API.
Comment 4 Chris Dumez 2017-01-27 13:09:17 PST 
Comment on attachment 299941 [details]
Patch

Clearing flags on attachment: 299941

Committed r211301: <http://trac.webkit.org/changeset/211301>
Comment 5 Chris Dumez 2017-01-27 13:09:21 PST 
All reviewed patches have been landed.  Closing bug.