Bug 167500

Summary: Merge CachedModuleScript and LoadableModuleScript
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 167501    
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2017-01-27 07:26:13 PST
Merge CachedModuleScript and LoadableModuleScript
Attachments
Patch (32.55 KB, patch)
2017-01-27 07:28 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-01-27 07:28:30 PST
Created attachment 299932 [details] Patch
WebKit Commit Bot
Comment 2 2017-01-27 07:31:38 PST
Attachment 299932 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/ScriptController.cpp:383: 'moduleScript' is incorrectly named. It should be named 'protector' or 'protectedModuleScriptRef'. [readability/naming/protected] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2017-01-27 16:23:34 PST
Comment on attachment 299932 [details] Patch Thanks!
WebKit Commit Bot
Comment 4 2017-01-27 16:48:53 PST
Comment on attachment 299932 [details] Patch Clearing flags on attachment: 299932 Committed r211313: <http://trac.webkit.org/changeset/211313>
WebKit Commit Bot
Comment 5 2017-01-27 16:48:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.