Bug 167478

Summary: [iOS] Add a test for _WKNSFileManagerExtras
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dbates, ddkilzer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=167455
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2017-01-26 17:10:16 PST
[iOS] Add a test for _WKNSFileManagerExtras
Attachments
Patch (7.84 KB, patch)
2017-01-26 17:13 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2017-01-26 19:36 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (7.86 KB, patch)
2017-01-27 20:09 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-01-26 17:13:45 PST
Created attachment 299885 [details] Patch
Andy Estes
Comment 2 2017-01-26 19:36:21 PST
Created attachment 299898 [details] Patch
Daniel Bates
Comment 3 2017-01-26 23:00:57 PST
Comment on attachment 299898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299898&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:36 > + EXPECT_TRUE(!!attributes); Is it necessary to force a conversion to bool? Also, it would be more idiomatic to include header "Test.h" and use EXPECT_NOT_NULL(). If we need to force conversion to bool then we should fix EXPECT_NOT_NULL() and EXPECT_NULL().
Andy Estes
Comment 4 2017-01-27 20:08:58 PST
(In reply to comment #3) > Comment on attachment 299898 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299898&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:36 > > + EXPECT_TRUE(!!attributes); > > Is it necessary to force a conversion to bool? Also, it would be more > idiomatic to include header "Test.h" and use EXPECT_NOT_NULL(). If we need > to force conversion to bool then we should fix EXPECT_NOT_NULL() and > EXPECT_NULL(). I didn't know about EXPECT_NOT_NULL(). I'll use that instead.
Andy Estes
Comment 5 2017-01-27 20:09:49 PST
Created attachment 299991 [details] Patch
WebKit Commit Bot
Comment 6 2017-01-27 21:06:57 PST
Comment on attachment 299991 [details] Patch Clearing flags on attachment: 299991 Committed r211322: <http://trac.webkit.org/changeset/211322>
WebKit Commit Bot
Comment 7 2017-01-27 21:07:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.