[iOS] Add a test for _WKNSFileManagerExtras
Created attachment 299885 [details] Patch
Created attachment 299898 [details] Patch
Comment on attachment 299898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299898&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:36 > + EXPECT_TRUE(!!attributes); Is it necessary to force a conversion to bool? Also, it would be more idiomatic to include header "Test.h" and use EXPECT_NOT_NULL(). If we need to force conversion to bool then we should fix EXPECT_NOT_NULL() and EXPECT_NULL().
(In reply to comment #3) > Comment on attachment 299898 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299898&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:36 > > + EXPECT_TRUE(!!attributes); > > Is it necessary to force a conversion to bool? Also, it would be more > idiomatic to include header "Test.h" and use EXPECT_NOT_NULL(). If we need > to force conversion to bool then we should fix EXPECT_NOT_NULL() and > EXPECT_NULL(). I didn't know about EXPECT_NOT_NULL(). I'll use that instead.
Created attachment 299991 [details] Patch
Comment on attachment 299991 [details] Patch Clearing flags on attachment: 299991 Committed r211322: <http://trac.webkit.org/changeset/211322>
All reviewed patches have been landed. Closing bug.