Bug 167478 - [iOS] Add a test for _WKNSFileManagerExtras
Summary: [iOS] Add a test for _WKNSFileManagerExtras
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-26 17:10 PST by Andy Estes
Modified: 2017-01-27 21:07 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.84 KB, patch)
2017-01-26 17:13 PST, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (7.84 KB, patch)
2017-01-26 19:36 PST, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (7.86 KB, patch)
2017-01-27 20:09 PST, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-01-26 17:10:16 PST
[iOS] Add a test for _WKNSFileManagerExtras
Comment 1 Andy Estes 2017-01-26 17:13:45 PST
Created attachment 299885 [details]
Patch
Comment 2 Andy Estes 2017-01-26 19:36:21 PST
Created attachment 299898 [details]
Patch
Comment 3 Daniel Bates 2017-01-26 23:00:57 PST
Comment on attachment 299898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299898&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:36
> +    EXPECT_TRUE(!!attributes);

Is it necessary to force a conversion to bool? Also, it would be more idiomatic to include header "Test.h" and use EXPECT_NOT_NULL(). If we need to force conversion to bool then we should fix EXPECT_NOT_NULL() and EXPECT_NULL().
Comment 4 Andy Estes 2017-01-27 20:08:58 PST
(In reply to comment #3)
> Comment on attachment 299898 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299898&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:36
> > +    EXPECT_TRUE(!!attributes);
> 
> Is it necessary to force a conversion to bool? Also, it would be more
> idiomatic to include header "Test.h" and use EXPECT_NOT_NULL(). If we need
> to force conversion to bool then we should fix EXPECT_NOT_NULL() and
> EXPECT_NULL().

I didn't know about EXPECT_NOT_NULL(). I'll use that instead.
Comment 5 Andy Estes 2017-01-27 20:09:49 PST
Created attachment 299991 [details]
Patch
Comment 6 WebKit Commit Bot 2017-01-27 21:06:57 PST
Comment on attachment 299991 [details]
Patch

Clearing flags on attachment: 299991

Committed r211322: <http://trac.webkit.org/changeset/211322>
Comment 7 WebKit Commit Bot 2017-01-27 21:07:01 PST
All reviewed patches have been landed.  Closing bug.