Bug 167467

Summary: QueueStatusServer should have an explicit timeout for _fetch_url
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, glenn, lforschler, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=167210
Attachments:
Description Flags
Proposed patch
none
Updated patch none

Aakash Jain
Reported 2017-01-26 14:03:06 PST
see rdar://problem/24792814
Attachments
Proposed patch (1.27 KB, patch)
2017-01-26 14:08 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (1.27 KB, patch)
2017-01-30 14:50 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-01-26 14:08:06 PST
Created attachment 299848 [details] Proposed patch
Alexey Proskuryakov
Comment 2 2017-01-27 13:52:52 PST
Comment on attachment 299848 [details] Proposed patch How long does this usually take? 15 seconds sounds short generally speaking, so I'd like to understand it better.
Aakash Jain
Comment 3 2017-01-30 13:43:46 PST
In the last hang, i noticed it took about 18s (from 22:10:31 to 22:10:49). We have only one data point right now (after the last time we added more logs). I can increase this timeout to 60s or 120s, my concern is that we should have explicit timeout, in order to avoid possibility of timeout being infinite.
Alexey Proskuryakov
Comment 4 2017-01-30 14:41:50 PST
If this is just to avoid infinite timeout, would making it 5 minutes makes sense?
Aakash Jain
Comment 5 2017-01-30 14:50:05 PST
Created attachment 300146 [details] Updated patch Yes, 5 minutes makes sense. Updated the patch.
WebKit Commit Bot
Comment 6 2017-01-30 15:23:21 PST
Comment on attachment 300146 [details] Updated patch Clearing flags on attachment: 300146 Committed r211389: <http://trac.webkit.org/changeset/211389>
WebKit Commit Bot
Comment 7 2017-01-30 15:23:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.