Summary: | QueueStatusServer should have an explicit timeout for _fetch_url | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, glenn, lforschler, ryanhaddad | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=167210 | ||||||||
Attachments: |
|
Description
Aakash Jain
2017-01-26 14:03:06 PST
Created attachment 299848 [details]
Proposed patch
Comment on attachment 299848 [details]
Proposed patch
How long does this usually take? 15 seconds sounds short generally speaking, so I'd like to understand it better.
In the last hang, i noticed it took about 18s (from 22:10:31 to 22:10:49). We have only one data point right now (after the last time we added more logs). I can increase this timeout to 60s or 120s, my concern is that we should have explicit timeout, in order to avoid possibility of timeout being infinite. If this is just to avoid infinite timeout, would making it 5 minutes makes sense? Created attachment 300146 [details]
Updated patch
Yes, 5 minutes makes sense. Updated the patch.
Comment on attachment 300146 [details] Updated patch Clearing flags on attachment: 300146 Committed r211389: <http://trac.webkit.org/changeset/211389> All reviewed patches have been landed. Closing bug. |