| Summary: | EventTarget should visit the JSEventListeners using visitAdditionalChildren | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||||||||||
| Component: | WebCore JavaScript | Assignee: | Filip Pizlo <fpizlo> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, ryanhaddad, simon.fraser, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||
| OS: | All | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Filip Pizlo
2017-01-26 12:49:16 PST
Created attachment 299836 [details]
the patch
Comment on attachment 299836 [details]
the patch
r=me
Comment on attachment 299836 [details] the patch Attachment 299836 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2954136 Number of test failures exceeded the failure limit. Created attachment 299841 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 299836 [details] the patch Attachment 299836 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2954135 Number of test failures exceeded the failure limit. Created attachment 299843 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 299836 [details] the patch Attachment 299836 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2954155 Number of test failures exceeded the failure limit. Created attachment 299844 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 299836 [details] the patch Attachment 299836 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2954175 Number of test failures exceeded the failure limit. Created attachment 299850 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 299855 [details]
the patch
Comment on attachment 299855 [details]
the patch
r=me
Comment on attachment 299855 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=299855&action=review > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:56 > + wrapped().visitJSEventListeners(visitor); Add a comment why this is needed here. Looks like the timeouts the bots are seeing are real. Comment on attachment 299855 [details] the patch Attachment 299855 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2954599 New failing tests: inspector/worker/worker-create-and-terminate.html inspector/worker/console-basic.html fast/canvas/webgl/typed-arrays-in-workers.html fast/workers/worker-messageport.html fast/workers/worker-close.html Created attachment 299864 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 299866 [details]
the patch
Comment on attachment 299866 [details]
the patch
r=me
Landed in https://trac.webkit.org/changeset/211238 This broke bindings tests: https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20%28Tests%29/builds/2735/steps/bindings-generation-tests/logs/stdio (In reply to comment #21) > This broke bindings tests: > https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20%28Tests%29/ > builds/2735/steps/bindings-generation-tests/logs/stdio I rebaselined the tests in https://trac.webkit.org/changeset/211285. |