Bug 167462

Summary:

EventTarget should visit the JSEventListeners using visitAdditionalChildren

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

WebCore JavaScript

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, ryanhaddad, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	msaboff: review+, buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
the patch	msaboff: review+, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan	none
the patch	msaboff: review+

Filip Pizlo

Reported 2017-01-26 12:49:16 PST

Patch forthcoming.

Attachments
the patch (3.69 KB, patch) 2017-01-26 12:53 PST, Filip Pizlo	msaboff: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (565.52 KB, application/zip) 2017-01-26 13:44 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (550.73 KB, application/zip) 2017-01-26 13:49 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.28 MB, application/zip) 2017-01-26 13:51 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (deleted) 2017-01-26 14:12 PST, Build Bot	no flags	Details
the patch (4.58 KB, patch) 2017-01-26 14:26 PST, Filip Pizlo	msaboff: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.00 MB, application/zip) 2017-01-26 15:29 PST, Build Bot	no flags	Details
the patch (6.45 KB, patch) 2017-01-26 15:42 PST, Filip Pizlo	msaboff: review+	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2017-01-26 12:53:37 PST

Created attachment 299836 [details] the patch

Radar WebKit Bug Importer

Comment 2 2017-01-26 12:53:54 PST

<rdar://problem/30216742>

Michael Saboff

Comment 3 2017-01-26 13:12:24 PST

Comment on attachment 299836 [details] the patch r=me

Build Bot

Comment 4 2017-01-26 13:44:15 PST

Comment on attachment 299836 [details] the patch Attachment 299836 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2954136 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2017-01-26 13:44:19 PST

Created attachment 299841 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-01-26 13:49:50 PST

Comment on attachment 299836 [details] the patch Attachment 299836 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2954135 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2017-01-26 13:49:54 PST

Created attachment 299843 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-01-26 13:51:20 PST

Comment on attachment 299836 [details] the patch Attachment 299836 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2954155 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2017-01-26 13:51:26 PST

Created attachment 299844 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 10 2017-01-26 14:12:41 PST

Comment on attachment 299836 [details] the patch Attachment 299836 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2954175 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2017-01-26 14:12:49 PST

Created attachment 299850 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Filip Pizlo

Comment 12 2017-01-26 14:26:53 PST

Created attachment 299855 [details] the patch

Michael Saboff

Comment 13 2017-01-26 14:34:58 PST

Comment on attachment 299855 [details] the patch r=me

Michael Saboff

Comment 14 2017-01-26 14:41:55 PST

Comment on attachment 299855 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=299855&action=review > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:56 > + wrapped().visitJSEventListeners(visitor); Add a comment why this is needed here.

Filip Pizlo

Comment 15 2017-01-26 15:23:17 PST

Looks like the timeouts the bots are seeing are real.

Build Bot

Comment 16 2017-01-26 15:29:30 PST

Comment on attachment 299855 [details] the patch Attachment 299855 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2954599 New failing tests: inspector/worker/worker-create-and-terminate.html inspector/worker/console-basic.html fast/canvas/webgl/typed-arrays-in-workers.html fast/workers/worker-messageport.html fast/workers/worker-close.html

Build Bot

Comment 17 2017-01-26 15:29:35 PST

Created attachment 299864 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Filip Pizlo

Comment 18 2017-01-26 15:42:35 PST

Created attachment 299866 [details] the patch

Michael Saboff

Comment 19 2017-01-26 15:43:36 PST

Comment on attachment 299866 [details] the patch r=me

Filip Pizlo

Comment 20 2017-01-26 16:13:35 PST

Landed in https://trac.webkit.org/changeset/211238

Simon Fraser (smfr)

Comment 21 2017-01-26 22:04:46 PST

This broke bindings tests: https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20%28Tests%29/builds/2735/steps/bindings-generation-tests/logs/stdio

Ryan Haddad

Comment 22 2017-01-27 09:32:20 PST

(In reply to comment #21) > This broke bindings tests: > https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20%28Tests%29/ > builds/2735/steps/bindings-generation-tests/logs/stdio I rebaselined the tests in https://trac.webkit.org/changeset/211285.

Note You need to log in before you can comment on or make changes to this bug.