Summary: | Remote Inspector: Listing should be updated when a target gains or loses a debugger session | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, commit-queue, inspector-bugzilla-changes, keith_miller, mark.lam, msaboff, saam, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-01-25 21:58:03 PST
Created attachment 299793 [details]
[PATCH] Proposed Fix
Comment on attachment 299793 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299793&action=review > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:622 > + auto target = m_targetMap.get(targetIdentifier); I think we're preferring the more explicit auto* and auto& for pointer and reference types (per recent discussions with Darin). Comment on attachment 299793 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299793&action=review r=me > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:619 > + This means caller must hold the listings lock before calling these, right? Comment on attachment 299793 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299793&action=review >> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:619 >> + > > This means caller must hold the listings lock before calling these, right? Yes Comment on attachment 299793 [details] [PATCH] Proposed Fix Clearing flags on attachment: 299793 Committed r211344: <http://trac.webkit.org/changeset/211344> All reviewed patches have been landed. Closing bug. |