| Summary: | Introduce an item-provider-based pasteboard wrapper | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||
| Component: | WebKit Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bdakin, benjamin, cdumez, cmarcelo, commit-queue, dbates, enrica | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Wenson Hsieh
2017-01-24 21:42:25 PST
Created attachment 299703 [details]
Patch
Comment on attachment 299703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299703&action=review > Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:73 > +@synthesize itemProviders=_itemProviders; I don't think these are needed. Created attachment 299732 [details]
Patch for landing
Comment on attachment 299732 [details] Patch for landing Rejecting attachment 299732 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 299732, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 211160 = f0a4af11283d42db3eafce5f7562729ef49dec95 r211161 = 0aa2d819faea817981312093c18d1bb9d7df199e r211162 = 65a30632ca1901b25f5a64db884beb5497155151 r211164 = 881e7c913de37fb394a9e4aba5ffd4d208fa001a Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2948541 Created attachment 299749 [details]
Patch for landing
Comment on attachment 299732 [details]
Patch for landing
Failure looks unrelated.
Created attachment 299750 [details]
Patch for landing
Comment on attachment 299750 [details] Patch for landing Rejecting attachment 299750 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 299750, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WTF/ChangeLog is not at the top of the file. Full output: http://webkit-queues.webkit.org/results/2948727 Created attachment 299754 [details]
Patch for landing
Comment on attachment 299750 [details]
Patch for landing
It looks like CQ could not process this patch because the date was off by 1 (?)
Comment on attachment 299754 [details] Patch for landing Clearing flags on attachment: 299754 Committed r211175: <http://trac.webkit.org/changeset/211175> |