WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
167410
Introduce an item-provider-based pasteboard wrapper
https://bugs.webkit.org/show_bug.cgi?id=167410
Summary
Introduce an item-provider-based pasteboard wrapper
Wenson Hsieh
Reported
2017-01-24 21:42:25 PST
Introduce an item-provider-based pasteboard wrapper
Attachments
Patch
(21.29 KB, patch)
2017-01-25 07:36 PST
,
Wenson Hsieh
enrica
: review+
Details
Formatted Diff
Diff
Patch for landing
(21.46 KB, patch)
2017-01-25 12:54 PST
,
Wenson Hsieh
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Patch for landing
(21.46 KB, patch)
2017-01-25 14:45 PST
,
Wenson Hsieh
wenson_hsieh
: commit-queue+
Details
Formatted Diff
Diff
Patch for landing
(21.42 KB, patch)
2017-01-25 14:49 PST
,
Wenson Hsieh
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Patch for landing
(21.27 KB, patch)
2017-01-25 15:13 PST
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2017-01-25 07:36:45 PST
Created
attachment 299703
[details]
Patch
Enrica Casucci
Comment 2
2017-01-25 09:33:34 PST
Comment on
attachment 299703
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=299703&action=review
> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:73 > +@synthesize itemProviders=_itemProviders;
I don't think these are needed.
Wenson Hsieh
Comment 3
2017-01-25 12:54:40 PST
Created
attachment 299732
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2017-01-25 14:16:23 PST
Comment on
attachment 299732
[details]
Patch for landing Rejecting
attachment 299732
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 299732, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 211160 = f0a4af11283d42db3eafce5f7562729ef49dec95
r211161
= 0aa2d819faea817981312093c18d1bb9d7df199e
r211162
= 65a30632ca1901b25f5a64db884beb5497155151
r211164
= 881e7c913de37fb394a9e4aba5ffd4d208fa001a Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output:
http://webkit-queues.webkit.org/results/2948541
Wenson Hsieh
Comment 5
2017-01-25 14:45:41 PST
Created
attachment 299749
[details]
Patch for landing
Wenson Hsieh
Comment 6
2017-01-25 14:48:53 PST
Comment on
attachment 299732
[details]
Patch for landing Failure looks unrelated.
Wenson Hsieh
Comment 7
2017-01-25 14:49:29 PST
Created
attachment 299750
[details]
Patch for landing
WebKit Commit Bot
Comment 8
2017-01-25 14:54:04 PST
Comment on
attachment 299750
[details]
Patch for landing Rejecting
attachment 299750
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 299750, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WTF/ChangeLog is not at the top of the file. Full output:
http://webkit-queues.webkit.org/results/2948727
Wenson Hsieh
Comment 9
2017-01-25 15:13:48 PST
Created
attachment 299754
[details]
Patch for landing
Wenson Hsieh
Comment 10
2017-01-25 15:14:49 PST
Comment on
attachment 299750
[details]
Patch for landing It looks like CQ could not process this patch because the date was off by 1 (?)
WebKit Commit Bot
Comment 11
2017-01-25 15:51:31 PST
Comment on
attachment 299754
[details]
Patch for landing Clearing flags on attachment: 299754 Committed
r211175
: <
http://trac.webkit.org/changeset/211175
>
Wenson Hsieh
Comment 12
2017-01-28 12:25:39 PST
<
rdar://problem/30107775
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug