Bug 167401

Summary: [iOS] Move WKPDFView's password view to WKWebView
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, manian, ossy, sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 167451    
Bug Blocks: 167407    
Attachments:
Description Flags
Patch none

Description Andy Estes 2017-01-24 18:21:46 PST
[iOS] Move WKPDFView's password view to WKWebView
Comment 1 Andy Estes 2017-01-24 19:03:28 PST
Created attachment 299663 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-25 12:49:59 PST
Comment on attachment 299663 [details]
Patch

Clearing flags on attachment: 299663

Committed r211160: <http://trac.webkit.org/changeset/211160>
Comment 3 WebKit Commit Bot 2017-01-25 12:50:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2017-01-25 13:21:26 PST
(In reply to comment #2)
> Comment on attachment 299663 [details]
> Patch
> 
> Clearing flags on attachment: 299663
> 
> Committed r211160: <http://trac.webkit.org/changeset/211160>

It broke the Apple Mac cmake build:

/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:60:9: fatal error: 'WKPasswordView.h' file not found
#import "WKPasswordView.h"
        ^
1 error generated.
Comment 5 Radar WebKit Bug Importer 2017-07-27 13:56:15 PDT
<rdar://problem/33575726>