Bug 167386

Summary: -0 is a valid array index and AtomicsObject should know this
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mark.lam: review+

Filip Pizlo
Reported 2017-01-24 14:48:14 PST
Patch forthcoming.
Attachments
the patch (2.70 KB, patch)
2017-01-24 14:52 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-01-24 14:50:23 PST
<rdar://problem/30174692>
Filip Pizlo
Comment 2 2017-01-24 14:52:31 PST
Created attachment 299633 [details] the patch
WebKit Commit Bot
Comment 3 2017-01-24 14:54:02 PST
Attachment 299633 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/AtomicsObject.cpp:113: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 4 2017-01-24 15:00:37 PST
Comment on attachment 299633 [details] the patch r=me
Filip Pizlo
Comment 5 2017-01-24 15:26:08 PST
Landed in https://trac.webkit.org/changeset/211113
Note You need to log in before you can comment on or make changes to this bug.