| Summary: | [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, commit-queue, jer.noble, mrajca | ||||
| Priority: | P2 | ||||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | iOS 10 | ||||||
| Attachments: |
|
||||||
|
Description
Ryan Haddad
2017-01-24 14:40:08 PST
The test was added with https://trac.webkit.org/changeset/211097 The JS used timeouts in the HTML test files might just have to be increased from 100 ms. Is there a way to test this without making a commit? I don't think EWS runs API tests. (In reply to comment #2) > The JS used timeouts in the HTML test files might just have to be increased > from 100 ms. Is there a way to test this without making a commit? I don't > think EWS runs API tests. If you have a build for the simulator, you can run API tests locally with: ./Tools/Scripts/run-api-tests --verbose --ios-simulator > If you have a build for the simulator, you can run API tests locally with:
>
> ./Tools/Scripts/run-api-tests --verbose --ios-simulator
Actually, make that:
./Tools/Scripts/run-api-tests --no-build --verbose --ios-simulator WebKit2.WebsitePoliciesAutoplayEnabled
This test expects "did-no-play" three times, so increasing the timeout would have quite cost. Isn't there a better way to detect the condition? Her would know for sure. *Jer*! (In reply to comment #6) > *Jer*! Calling video.play() will now return a Promise, which will reject if playback is not allowed. Seems like the test could use that rather than waiting to see if playback doesn't start. Created attachment 299753 [details]
Patch
Comment on attachment 299753 [details] Patch Clearing flags on attachment: 299753 Committed r211174: <http://trac.webkit.org/changeset/211174> All reviewed patches have been landed. Closing bug. |