Bug 167372

Summary: LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, jonlee
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing
none
Patch for landing
none
Patch for landing none

Ryan Haddad
Reported 2017-01-24 08:18:04 PST
LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html is a flaky failure https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r211078%20(11017)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmacos-fullscreen-media-controls%2Fmacos-fullscreen-media-controls-buttons-styles.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-actual.txt @@ -9,12 +9,12 @@ PASS style.height is "44px" PlayPauseButton -PASS style.left is "78px" +FAIL style.left should be 78px. Was 54px. PASS style.webkitMaskPositionY is "12px" PASS style.height is "44px" ForwardButton -PASS style.left is "127px" +FAIL style.left should be 127px. Was 81px. PASS style.webkitMaskPositionY is "16px" PASS style.height is "44px" @@ -24,17 +24,17 @@ PASS style.height is "44px" PiPButton -PASS style.left is "44px" +FAIL style.left should be 44px. Was 28px. PASS style.webkitMaskPositionY is "13px" PASS style.height is "44px" TracksButton -PASS style.left is "82px" +FAIL style.left should be 82px. Was 44px. PASS style.webkitMaskPositionY is "15px" PASS style.height is "44px" FullscreenButton -PASS style.left is "114px" +FAIL style.left should be 114px. Was 60px. PASS style.webkitMaskPositionY is "13px" PASS style.height is "44px"
Attachments
Patch for landing (1.63 KB, patch)
2017-02-02 05:27 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.63 KB, patch)
2017-02-02 05:29 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.19 KB, patch)
2017-02-14 06:55 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2017-01-24 08:21:36 PST
This seems to be limited to macOS Debug WK1.
Ryan Haddad
Comment 2 2017-01-24 12:50:57 PST
Marked as flaky in https://trac.webkit.org/r211096
Jon Lee
Comment 3 2017-01-24 12:55:27 PST
Ryan said he was seeing this on EWS also.
Antoine Quint
Comment 4 2017-02-02 05:27:12 PST
Created attachment 300402 [details] Patch for landing
Antoine Quint
Comment 5 2017-02-02 05:29:04 PST
Created attachment 300403 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-02-02 07:01:01 PST
Comment on attachment 300403 [details] Patch for landing Clearing flags on attachment: 300403 Committed r211558: <http://trac.webkit.org/changeset/211558>
WebKit Commit Bot
Comment 7 2017-02-02 07:01:05 PST
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 8 2017-02-10 12:21:40 PST
Still flaky
Antoine Quint
Comment 9 2017-02-14 06:55:45 PST
Created attachment 301494 [details] Patch for landing
WebKit Commit Bot
Comment 10 2017-02-14 08:24:57 PST
Comment on attachment 301494 [details] Patch for landing Clearing flags on attachment: 301494 Committed r212293: <http://trac.webkit.org/changeset/212293>
WebKit Commit Bot
Comment 11 2017-02-14 08:25:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.