Bug 167363

Summary: Some complex text with initial advances is misplaced
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED DUPLICATE    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP none

Myles C. Maxfield
Reported 2017-01-24 01:26:09 PST
Some complex text with initial advances is misplaced
Attachments
WIP (21.95 KB, patch)
2017-01-24 01:27 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-01-24 01:27:05 PST
Created attachment 299585 [details] WIP
Myles C. Maxfield
Comment 2 2017-01-24 01:32:52 PST
*** This bug has been marked as a duplicate of bug 166013 ***
Myles C. Maxfield
Comment 3 2017-01-24 15:43:19 PST
Comment on attachment 299585 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=299585&action=review > Source/WebCore/platform/graphics/mac/ComplexTextController.h:94 > const UChar* characters() const { return m_characters; } No need for ComplexTextRun to be RefCounted (Probably)
Myles C. Maxfield
Comment 4 2017-01-24 15:53:45 PST
Comment on attachment 299585 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=299585&action=review > Source/WebCore/platform/graphics/mac/ComplexTextController.h:100 > CFIndex endOffsetAt(size_t i) const { ASSERT(!m_isMonotonic); return m_glyphEndOffsets[i]; } m_isMonotonic { true }
Note You need to log in before you can comment on or make changes to this bug.