Bug 167345

Summary: Web Inspector: Provide a way to trigger a Garbage Collection
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bburg, commit-queue, ggaren, inspector-bugzilla-changes, joepeck, jond, keith_miller, mark.lam, mitz, msaboff, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Garbage Collect button in Console - New Clear Icon
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-01-23 17:19:34 PST
Summary: Provide a way to trigger a Garbage Collection Sometimes developers want to just perform a GC. We already have the capability, we should expose a button in Web Inspector to do this.
Attachments
[IMAGE] Garbage Collect button in Console - New Clear Icon (231.50 KB, image/png)
2017-01-23 17:27 PST, Joseph Pecoraro
no flags
[PATCH] Proposed Fix (126.58 KB, patch)
2017-01-23 17:27 PST, Joseph Pecoraro
no flags
Joseph Pecoraro
Comment 1 2017-01-23 17:20:04 PST
Joseph Pecoraro
Comment 2 2017-01-23 17:27:40 PST
Created attachment 299560 [details] [IMAGE] Garbage Collect button in Console - New Clear Icon
Joseph Pecoraro
Comment 3 2017-01-23 17:27:59 PST
Created attachment 299561 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 4 2017-01-23 17:30:55 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Timothy Hatcher
Comment 5 2017-01-23 17:34:15 PST
Comment on attachment 299561 [details] [PATCH] Proposed Fix I like the clear icon, but I wasn't sure about the collect icon. I'm blank on ideas though. Memory chip half full?
WebKit Commit Bot
Comment 6 2017-01-23 19:20:21 PST
Comment on attachment 299561 [details] [PATCH] Proposed Fix Clearing flags on attachment: 299561 Committed r211075: <http://trac.webkit.org/changeset/211075>
WebKit Commit Bot
Comment 7 2017-01-23 19:20:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.