Bug 167315

Summary:

JavaScriptCore fails to build on Linux because -lpthread is missing

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

WebKit Misc.

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

achristensen

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	timothy: review-

Description Timothy Hatcher 2017-01-23 11:27:47 PST

We need to add find_package(Threads) to Source/cmake/WebKitCommon.cmake to make it link correctly like I needed to do in bug 167313.

Comment 1 Timothy Hatcher 2017-01-23 11:29:45 PST

Created attachment 299528 [details]
Patch

Comment 2 Alex Christensen 2017-01-23 11:48:38 PST

Comment on attachment 299528 [details]
Patch

If this is only needed on Linux, should this be in WebKitCommon?  Are you using the GTK port?

Comment 3 Timothy Hatcher 2017-01-23 11:54:17 PST

I found the error in my end with my Cmake options. This is a different Linux port.