Bug 167314

Summary: Use priorities in speculative revalidation
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, cgarcia, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch cdumez: review+

Antti Koivisto
Reported 2017-01-23 11:11:00 PST
We currently do all speculative cache operations with 'Medium' priority and network operations with 'Low'. We should use the actual request priorities instead.
Attachments
patch (7.35 KB, patch)
2017-01-23 12:09 PST, Antti Koivisto 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-01-23 12:09:52 PST
Created attachment 299530 [details] patch
Chris Dumez
Comment 2 2017-01-23 12:14:36 PST
Comment on attachment 299530 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=299530&action=review r=me > Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:492 > + spacing issue. > Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:536 > + m_storage.retrieve(subresourcesStorageKey, static_cast<unsigned>(WebCore::ResourceLoadPriority::High), [completionHandler = WTFMove(completionHandler)](auto record) { Why the extra WebCore:: ? The priority change might be risky as I used that value based on PLT results.
Antti Koivisto
Comment 3 2017-01-23 12:23:27 PST
https://trac.webkit.org/r211049
Radar WebKit Bug Importer
Comment 4 2017-02-01 06:04:11 PST
<rdar://problem/30306336>
Note You need to log in before you can comment on or make changes to this bug.