Bug 167311

Summary:

LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Ryan Haddad 2017-01-23 09:28:51 PST

LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r211038%20(2629)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Ftracks-panel%2Ftracks-panel-hide.html

Comment 1 Ryan Haddad 2017-01-23 13:29:53 PST

This appears to be limited to macOS debug.

Comment 2 Ryan Haddad 2017-01-23 13:32:59 PST

Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/211059

Comment 3 Antoine Quint 2017-01-24 14:06:34 PST

The timeout is caused by the "transitionend" event not being fired.

Comment 4 Antoine Quint 2017-01-24 14:11:55 PST

This looks like a bug in the TracksPanel class where we register for the "transitionend" event at the same time we apply the "fade-out" class that triggers the transition. But in case the value we're animating from is already 0, we won't have a chance to transition and there will be no event. So we need to register for the event first and delay the transition until the next frame.

Comment 5 Antoine Quint 2017-01-24 14:19:04 PST

Created attachment 299631 [details]
Patch

Comment 6 WebKit Commit Bot 2017-01-24 19:00:28 PST

Comment on attachment 299631 [details]
Patch

Clearing flags on attachment: 299631

Committed r211131: <http://trac.webkit.org/changeset/211131>

Comment 7 WebKit Commit Bot 2017-01-24 19:00:31 PST

All reviewed patches have been landed.  Closing bug.