Bug 167311

Summary: LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Attachments
Patch (3.26 KB, patch)
2017-01-24 14:19 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2017-01-23 13:29:53 PST
This appears to be limited to macOS debug.
Ryan Haddad
Comment 2 2017-01-23 13:32:59 PST
Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/211059
Antoine Quint
Comment 3 2017-01-24 14:06:34 PST
The timeout is caused by the "transitionend" event not being fired.
Antoine Quint
Comment 4 2017-01-24 14:11:55 PST
This looks like a bug in the TracksPanel class where we register for the "transitionend" event at the same time we apply the "fade-out" class that triggers the transition. But in case the value we're animating from is already 0, we won't have a chance to transition and there will be no event. So we need to register for the event first and delay the transition until the next frame.
Antoine Quint
Comment 5 2017-01-24 14:19:04 PST
Created attachment 299631 [details] Patch
WebKit Commit Bot
Comment 6 2017-01-24 19:00:28 PST
Comment on attachment 299631 [details] Patch Clearing flags on attachment: 299631 Committed r211131: <http://trac.webkit.org/changeset/211131>
WebKit Commit Bot
Comment 7 2017-01-24 19:00:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.