Bug 167303

Summary: [JSC] Optimize Number#toString with Int52
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Yusuke Suzuki
Reported 2017-01-23 06:06:56 PST
Currently, Int52 cases are just handled in double context. We should have a fast path for that since it is frequently called in kraken crypto.
Attachments
Patch (6.86 KB, patch)
2017-01-23 06:29 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (9.84 KB, patch)
2017-01-24 03:43 PST, Yusuke Suzuki 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-01-23 06:07:54 PST
First, I'll implement this optimization in runtime function, it should offer perf boost for all the tiers. After that, I'll investigate DFG / FTL Number#toString handling.
Yusuke Suzuki
Comment 2 2017-01-23 06:29:14 PST
Created attachment 299513 [details] Patch
Yusuke Suzuki
Comment 3 2017-01-24 03:43:45 PST
Created attachment 299595 [details] Patch
Yusuke Suzuki
Comment 4 2017-01-24 18:42:12 PST
Committed r211128: <http://trac.webkit.org/changeset/211128>
Note You need to log in before you can comment on or make changes to this bug.