Bug 167292

Summary:

[Xcode] Clean up PAL and WebCore’s build settings a little

Product:

WebKit

Reporter:

mitz

Component:

Platform

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, mmaxfield

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Tidy things up a bit	mmaxfield: review+
Tidy up	sam: review+

mitz

Reported 2017-01-22 10:29:03 PST

Patch forthcoming.

Attachments
Tidy things up a bit (7.23 KB, patch) 2017-01-22 10:33 PST, mitz	mmaxfield: review+	Details Formatted Diff Diff
Tidy up (10.92 KB, patch) 2017-01-28 08:44 PST, mitz	sam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2017-01-22 10:33:42 PST

Created attachment 299470 [details] Tidy things up a bit

Myles C. Maxfield

Comment 2 2017-01-22 22:57:47 PST

Comment on attachment 299470 [details] Tidy things up a bit View in context: https://bugs.webkit.org/attachment.cgi?id=299470&action=review > Source/WebCore/ChangeLog:22 > + * PAL/Configurations/Base.xcconfig: Simplified the definition of > + GCC_WARN_64_TO_32_BIT_CONVERSION, removed the unused build setting PREBINDING, removed > + a duplicate definition of GCC_GENERATE_DEBUGGING_SYMBOLS, and removed definitions specific > + to OS X versions that are no longer supported. > + > + * PAL/Configurations/DebugRelease.xcconfig: Removed definitions specific to OS X versions > + that are no longer supported. > + > + * PAL/Configurations/PAL.xcconfig: Removed header search paths that do not exist or do not > + make sense. Simplified the definitions of INSTALL_PATH and SKIP_INSTALL. Removed the > + unusued build settings PRODUCT_BUNDLE_IDENTIFIER and > + WK_PREFIXED_IPHONEOS_DEPLOYMENT_TARGET. Removed the redundant definition of > + EXECUTABLE_PREFIX. > + > + * PAL/PAL.xcodeproj/project.pbxproj: Sorted the Configurations group. Shouldn't this stuff also be done in WebCore too?

Alex Christensen

Comment 3 2017-01-23 09:46:26 PST

If we intend to eventually move PAL to its own subdirectory of Source, shouldn't we add a ChangeLog sooner rather than later to have a more complete change history when we move it?

mitz

Comment 4 2017-01-23 09:47:12 PST

(In reply to comment #3) > If we intend to eventually move PAL to its own subdirectory of Source, > shouldn't we add a ChangeLog sooner rather than later to have a more > complete change history when we move it? Yes. Not sure how your question relates to this bug :)

Alex Christensen

Comment 5 2017-01-23 10:02:24 PST

This bug makes changes to PAL and has a ChangeLog entry...in WebCore

mitz

Comment 6 2017-01-28 08:44:14 PST

Created attachment 300035 [details] Tidy up

mitz

Comment 7 2017-01-28 10:06:49 PST

Committed <https://trac.webkit.org/r211338>.

Note You need to log in before you can comment on or make changes to this bug.