Bug 167257

Summary: [WebRTC] Make VP8 optional in libwebrtc
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, anton.venema, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2017-01-20 14:35:35 PST
[WebRTC] Make VP8 optional in libwebrtc
Attachments
Patch (10.60 KB, patch)
2017-01-20 14:40 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-01-20 14:40:01 PST
Created attachment 299389 [details] Patch
WebKit Commit Bot
Comment 2 2017-01-20 14:41:14 PST
Attachment 299389 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:22: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:30: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-01-23 11:33:53 PST
Comment on attachment 299389 [details] Patch Clearing flags on attachment: 299389 Committed r211046: <http://trac.webkit.org/changeset/211046>
WebKit Commit Bot
Comment 4 2017-01-23 11:33:57 PST
All reviewed patches have been landed. Closing bug.
Anton Venema
Comment 5 2018-01-03 09:20:37 PST
Since VP8 is a MTI video codec for WebRTC, what reason is there to make it optional in libwebrtc?
Note You need to log in before you can comment on or make changes to this bug.