Bug 167253 – LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html is flaky

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html is flaky 

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r210975%20(2974)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmacos-fullscreen-media-controls%2Fmacos-fullscreen-media-controls-buttons-containers-styles.html

--- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-actual.txt
@@ -3,14 +3,14 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS centerContainerBounds.left is 311
+FAIL centerContainerBounds.left should be 311. Was 346.
 PASS centerContainerBounds.top is 500
-PASS centerContainerBounds.width is 178
+FAIL centerContainerBounds.width should be 178. Was 108.
 PASS centerContainerBounds.height is 44
 
-PASS rightContainerBounds.left is within 0.5 of 493
+FAIL rightContainerBounds.left should be within 0.5 of 493. Was 562.
 PASS rightContainerBounds.top is 500
-PASS rightContainerBounds.width is within 0.5 of 141
+FAIL rightContainerBounds.width should be within 0.5 of 141. Was 72.
 PASS rightContainerBounds.height is 44
 
 PASS successfullyParsed is true

[Ryan Haddad]

Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/210984

[Antoine Quint]

I can get this test to fail fairly reliably with repeated runs and a dedicated instance: Tools/Scripts/run-webkit-tests --debug -1 -g --no-retry --no-sample-on-timeout --time-out-ms=10000 --run-singly --iterations=100 --exit-after-n-failures=1 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html

[Antoine Quint]

The problem is a source issue with IconButton where we don't notify the layout delegate when the image metrics has changed, so we can get in situations where the layout of the buttons container is incorrect, based on 0-width buttons. The test itself is correct.

[Antoine Quint]

Created attachment 299692 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 299692 [details]
Patch

Clearing flags on attachment: 299692

Committed r211154: <http://trac.webkit.org/changeset/211154>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.