| Summary: | Land the stochastic space-time scheduler disabled | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 167248 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2017-01-20 12:56:40 PST
Created attachment 299370 [details]
the patch
Attachment 299370 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.cpp:106: Declaration has space between type name and * in constraintExecutionDuration * m_pauseScale [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/heap/Heap.cpp:58: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 299436 [details]
more
Having tuned it I'm seeing some wins but now I need to verify that I didn't break perf of the old scheduler.
I sorta want to land with the new scheduler disabled because I had to make other changes and I want to make sure that those changes don't mess anything up.
Created attachment 299491 [details]
the patch
Attachment 299491 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.cpp:106: Declaration has space between type name and * in constraintExecutionDuration * m_pauseScale [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/heap/Heap.cpp:58: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 299491 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=299491&action=review r=me > Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.cpp:2 > + * Copyright (C) 2016-2017 Apple Inc. All rights reserved. 2017 > Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.h:2 > + * Copyright (C) 2016-2017 Apple Inc. All rights reserved. 2017 Landed in https://trac.webkit.org/changeset/211069 |