Bug 167228

Summary: Cleanup RuntimeEnabledFeatures
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, dbates, dino, joepeck, rniwa, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 167185    
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix
buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews102 for mac-elcapitan
none
Archive of layout-test-results from ews116 for mac-elcapitan
none
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix
simon.fraser: review+, buildbot: commit-queue-
[PATCH] Proposed Fix
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan
none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews113 for mac-elcapitan
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Archive of layout-test-results from ews116 for mac-elcapitan
none
Archive of layout-test-results from ews102 for mac-elcapitan
none
[PATCH] For Bots none

Joseph Pecoraro
Reported 2017-01-19 20:28:50 PST
Cleanup RuntimeEnabledFeatures - Remove unused features - Initialize all members - Move things around a bit to make it more readable - Document features that never change or are not used but have APIs
Attachments
[PATCH] Proposed Fix (36.48 KB, patch)
2017-01-19 20:33 PST, Joseph Pecoraro
no flags
[PATCH] Proposed Fix (36.68 KB, patch)
2017-01-19 21:03 PST, Joseph Pecoraro
no flags
[PATCH] Proposed Fix (36.83 KB, patch)
2017-01-19 21:59 PST, Joseph Pecoraro
buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (466.01 KB, application/zip)
2017-01-19 22:54 PST, Build Bot
no flags
Archive of layout-test-results from ews102 for mac-elcapitan (823.55 KB, application/zip)
2017-01-19 23:09 PST, Build Bot
no flags
Archive of layout-test-results from ews116 for mac-elcapitan (1.63 MB, application/zip)
2017-01-19 23:27 PST, Build Bot
no flags
[PATCH] Proposed Fix (84.01 KB, patch)
2017-01-20 12:16 PST, Joseph Pecoraro
no flags
[PATCH] Proposed Fix (93.90 KB, patch)
2017-01-20 13:09 PST, Joseph Pecoraro
simon.fraser: review+
buildbot: commit-queue-
[PATCH] Proposed Fix (94.52 KB, patch)
2017-01-20 13:45 PST, Joseph Pecoraro
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan (866.74 KB, application/zip)
2017-01-20 14:09 PST, Build Bot
no flags
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (885.36 KB, application/zip)
2017-01-20 14:25 PST, Build Bot
no flags
Archive of layout-test-results from ews113 for mac-elcapitan (1.64 MB, application/zip)
2017-01-20 14:29 PST, Build Bot
no flags
Archive of layout-test-results from ews121 for ios-simulator-wk2 (15.30 MB, application/zip)
2017-01-20 14:37 PST, Build Bot
no flags
Archive of layout-test-results from ews116 for mac-elcapitan (1.71 MB, application/zip)
2017-01-20 14:58 PST, Build Bot
no flags
Archive of layout-test-results from ews102 for mac-elcapitan (897.27 KB, application/zip)
2017-01-20 15:07 PST, Build Bot
no flags
[PATCH] For Bots (95.19 KB, patch)
2017-01-20 15:55 PST, Joseph Pecoraro
no flags
Joseph Pecoraro
Comment 1 2017-01-19 20:33:03 PST
Created attachment 299308 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2017-01-19 20:59:24 PST
Comment on attachment 299308 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299308&action=review > Source/WebCore/page/RuntimeEnabledFeatures.cpp:113 > +#if ENABLE(FETCH_API) > + m_isFetchAPIEnabled = false; > +#endif Tests are failing because I'm setting the value here. Previously reset() was never setting this. For all ports that enable the Fetch API this feature is on. (All but WinCairo?) So I'm going to change this to `true` and see how things go. That better matches the expectations of all ports right now.
Joseph Pecoraro
Comment 3 2017-01-19 21:03:30 PST
Created attachment 299311 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 4 2017-01-19 21:53:45 PST
Comment on attachment 299311 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299311&action=review > Source/WebCore/page/RuntimeEnabledFeatures.cpp:116 > +#if ENABLE(DOWNLOAD_ATTRIBUTE) > + m_isDownloadAttributeEnabled = false; > +#endif Different story here. This is enabled by WebKit2, disabled by WebKit1. reset() previous was not resetting this value. I'll have to do something custom here.
Joseph Pecoraro
Comment 5 2017-01-19 21:59:46 PST
Created attachment 299316 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 6 2017-01-19 22:32:32 PST
Comment on attachment 299316 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299316&action=review > Source/WebCore/page/RuntimeEnabledFeatures.cpp:49 > void RuntimeEnabledFeatures::reset() This is impossible to make the tests happy when reset is just wrong. I'll remove it battle the failures after removing it (which should be less then battling the failures with it...)
Build Bot
Comment 7 2017-01-19 22:54:35 PST
Comment on attachment 299316 [details] [PATCH] Proposed Fix Attachment 299316 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2918659 Number of test failures exceeded the failure limit.
Build Bot
Comment 8 2017-01-19 22:54:39 PST
Created attachment 299321 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 9 2017-01-19 23:09:29 PST
Comment on attachment 299316 [details] [PATCH] Proposed Fix Attachment 299316 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2918709 New failing tests: webgl/webgl2-rendering-context-obtain.html
Build Bot
Comment 10 2017-01-19 23:09:33 PST
Created attachment 299322 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 11 2017-01-19 23:27:05 PST
Comment on attachment 299316 [details] [PATCH] Proposed Fix Attachment 299316 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2918741 New failing tests: webgl/webgl2-rendering-context-obtain.html
Build Bot
Comment 12 2017-01-19 23:27:09 PST
Created attachment 299325 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Joseph Pecoraro
Comment 13 2017-01-20 12:16:53 PST
Created attachment 299367 [details] [PATCH] Proposed Fix I feel pretty good about this one.
Joseph Pecoraro
Comment 14 2017-01-20 13:09:47 PST
Created attachment 299371 [details] [PATCH] Proposed Fix Updated a few tests to new internals APIs. Updated DRT to better match WTR for experimental features.
Joseph Pecoraro
Comment 15 2017-01-20 13:45:48 PST
Created attachment 299378 [details] [PATCH] Proposed Fix Fixed 1 other test misuse of internals.
Build Bot
Comment 16 2017-01-20 14:09:47 PST
Comment on attachment 299371 [details] [PATCH] Proposed Fix Attachment 299371 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2921924 New failing tests: fast/dom/navigator-detached-no-crash.html http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html
Build Bot
Comment 17 2017-01-20 14:09:51 PST
Created attachment 299380 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 18 2017-01-20 14:25:31 PST
Comment on attachment 299371 [details] [PATCH] Proposed Fix Attachment 299371 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2921989 New failing tests: http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html
Build Bot
Comment 19 2017-01-20 14:25:35 PST
Created attachment 299383 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 20 2017-01-20 14:28:58 PST
Comment on attachment 299371 [details] [PATCH] Proposed Fix Attachment 299371 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2921980 New failing tests: fast/dom/navigator-detached-no-crash.html http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html
Build Bot
Comment 21 2017-01-20 14:29:03 PST
Created attachment 299384 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 22 2017-01-20 14:37:08 PST
Comment on attachment 299371 [details] [PATCH] Proposed Fix Attachment 299371 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2922003 New failing tests: http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html
Build Bot
Comment 23 2017-01-20 14:37:14 PST
Created attachment 299387 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 24 2017-01-20 14:58:28 PST
Comment on attachment 299378 [details] [PATCH] Proposed Fix Attachment 299378 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2922094 New failing tests: fast/dom/navigator-detached-no-crash.html
Build Bot
Comment 25 2017-01-20 14:58:33 PST
Created attachment 299391 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 26 2017-01-20 15:07:16 PST
Comment on attachment 299378 [details] [PATCH] Proposed Fix Attachment 299378 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2922158 New failing tests: fast/dom/navigator-detached-no-crash.html
Build Bot
Comment 27 2017-01-20 15:07:21 PST
Created attachment 299393 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Joseph Pecoraro
Comment 28 2017-01-20 15:55:41 PST
Created attachment 299399 [details] [PATCH] For Bots
Joseph Pecoraro
Comment 29 2017-01-20 18:19:25 PST
Bots are green!
Joseph Pecoraro
Comment 30 2017-01-20 18:25:58 PST
Alexey Proskuryakov
Comment 31 2017-01-21 23:45:05 PST
Joseph Pecoraro
Comment 32 2017-01-22 22:19:41 PST
(In reply to comment #31) > Looks like this broke js/dom/global-constructors-attributes.html on Sierra > WK1: > > https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/ > r211025%20(3005)/js/dom/global-constructors-attributes-diff.txt Thanks for bringing this to my attention. I'll rebaseline. I think this is a progression, we are enabling experimental features in layout tests. If you think this is incorrect for WebKit1 let me know and I can modify our approach.
Joseph Pecoraro
Comment 33 2017-01-22 22:22:54 PST
Joseph Pecoraro
Comment 34 2017-02-09 16:25:09 PST
*** Bug 167185 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.