Bug 167192

Summary: [iOS] Move the PDF password view into its own class for reuse
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andy Estes 2017-01-18 20:13:04 PST
[iOS] Move the PDF password view into its own class for possible reuse
Comment 1 Andy Estes 2017-01-18 20:24:12 PST
Created attachment 299220 [details]
Patch
Comment 2 Andy Estes 2017-01-18 20:27:43 PST
Created attachment 299222 [details]
Patch
Comment 3 Alex Christensen 2017-01-18 23:14:24 PST
Comment on attachment 299222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299222&action=review

> Source/WebCore/ChangeLog:3
> +        [iOS] Move the PDF password view into its own class for possible reuse

"possible"
lol
Comment 4 Andy Estes 2017-01-19 03:24:28 PST
(In reply to comment #3)
> Comment on attachment 299222 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299222&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [iOS] Move the PDF password view into its own class for possible reuse
> 
> "possible"
> lol

I don't know why I said that :(

Thanks for the review. After thinking more about this, I'd like to take a slightly different approach, so I'll probably post another patch.
Comment 5 Andy Estes 2017-01-19 14:54:06 PST
Created attachment 299271 [details]
Patch
Comment 6 WebKit Commit Bot 2017-01-19 16:25:07 PST
Comment on attachment 299271 [details]
Patch

Clearing flags on attachment: 299271

Committed r210943: <http://trac.webkit.org/changeset/210943>
Comment 7 WebKit Commit Bot 2017-01-19 16:25:11 PST
All reviewed patches have been landed.  Closing bug.