| Summary: | WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync should be Delayed reply messages | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | buildbot, ggaren, jberlin, mrajca, rniwa, sam | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Alex Christensen
2017-01-18 16:34:37 PST
Created attachment 299202 [details]
Patch
Comment on attachment 299202 [details] Patch Attachment 299202 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2912153 Number of test failures exceeded the failure limit. Created attachment 299204 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Can you explain why they should be Delayed reply messages? The ChangeLog really should include that information as well. Created attachment 299287 [details]
Patch
*** Bug 167129 has been marked as a duplicate of this bug. *** Comment on attachment 299287 [details] Patch Attachment 299287 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2917363 Number of test failures exceeded the failure limit. Created attachment 299293 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 304966 [details]
Patch
Comment on attachment 304966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304966&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:2318 > m_process->send(Messages::WebPage::DidReceivePolicyDecision(frame.frameID(), listenerID, action, navigation ? navigation->navigationID() : 0, downloadID), m_pageID); Can you remove this? Created attachment 304971 [details]
Patch
|