Bug 167183

Summary: WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync should be Delayed reply messages
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, ggaren, jberlin, mrajca, rniwa, sam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
none
Patch
none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
none
Patch
none
Patch none

Alex Christensen
Reported 2017-01-18 16:34:37 PST
WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync should be Delayed reply messages
Attachments
Patch (22.49 KB, patch)
2017-01-18 16:35 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.96 MB, application/zip)
2017-01-18 17:15 PST, Build Bot 		no flags
Details
Patch (23.44 KB, patch)
2017-01-19 17:03 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.17 MB, application/zip)
2017-01-19 17:44 PST, Build Bot 		no flags
Details
Patch (25.20 KB, patch)
2017-03-20 16:40 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (24.95 KB, patch)
2017-03-20 17:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-01-18 16:35:42 PST
Created attachment 299202 [details] Patch
Build Bot
Comment 2 2017-01-18 17:15:55 PST
Comment on attachment 299202 [details] Patch Attachment 299202 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2912153 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2017-01-18 17:15:57 PST
Created attachment 299204 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Sam Weinig
Comment 4 2017-01-18 17:21:43 PST
Can you explain why they should be Delayed reply messages? The ChangeLog really should include that information as well.
Alex Christensen
Comment 5 2017-01-19 17:03:31 PST
Created attachment 299287 [details] Patch
Alex Christensen
Comment 6 2017-01-19 17:40:28 PST
*** Bug 167129 has been marked as a duplicate of this bug. ***
Build Bot
Comment 7 2017-01-19 17:44:31 PST
Comment on attachment 299287 [details] Patch Attachment 299287 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2917363 Number of test failures exceeded the failure limit.
Build Bot
Comment 8 2017-01-19 17:44:34 PST
Created attachment 299293 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Jessie Berlin
Comment 9 2017-03-20 15:59:22 PDT
rdar://problem/30203539
Alex Christensen
Comment 10 2017-03-20 16:40:59 PDT
Created attachment 304966 [details] Patch
Andy Estes
Comment 11 2017-03-20 16:49:36 PDT
Comment on attachment 304966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304966&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:2318 > m_process->send(Messages::WebPage::DidReceivePolicyDecision(frame.frameID(), listenerID, action, navigation ? navigation->navigationID() : 0, downloadID), m_pageID); Can you remove this?
Alex Christensen
Comment 12 2017-03-20 17:14:02 PDT
Created attachment 304971 [details] Patch
Alex Christensen
Comment 13 2017-03-20 18:14:06 PDT
http://trac.webkit.org/r214201
Note You need to log in before you can comment on or make changes to this bug.