Bug 167180

Summary:

Use anonymous namespace for DeferredPageDestructor

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebKit Website

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

buildbot, cdumez, darin, ggaren, joepeck, jond, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-elcapitan	none
[PATCH] Proposed Fix	joepeck: review-

Joseph Pecoraro

Reported 2017-01-18 15:18:02 PST

Use anonymous namespace for DeferredPageDestructor in WebKit1. Don't use the WebKit namespace reserved for things in WebKit2.

Attachments
[PATCH] Proposed Fix (1.53 KB, patch) 2017-01-18 15:18 PST, Joseph Pecoraro	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (915.55 KB, application/zip) 2017-01-18 16:14 PST, Build Bot	no flags	Details
[PATCH] Proposed Fix (1.53 KB, patch) 2017-01-18 16:38 PST, Joseph Pecoraro	joepeck: review-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-01-18 15:18:50 PST

Created attachment 299194 [details] [PATCH] Proposed Fix

Build Bot

Comment 2 2017-01-18 16:14:32 PST

Comment on attachment 299194 [details] [PATCH] Proposed Fix Attachment 299194 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2911849 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html

Build Bot

Comment 3 2017-01-18 16:14:35 PST

Created attachment 299199 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Joseph Pecoraro

Comment 4 2017-01-18 16:38:20 PST

All failures unrelated. Just going to reupload the same patch.

Joseph Pecoraro

Comment 5 2017-01-18 16:38:52 PST

Created attachment 299203 [details] [PATCH] Proposed Fix

Alex Christensen

Comment 6 2017-01-18 23:24:04 PST

Comment on attachment 299203 [details] [PATCH] Proposed Fix Why just this? There are lots of places we have namespace WebKit in WebKit1. There are even a few places we have comments saying end of namespace WebKit in WebCore, probably from things we moved.

Chris Dumez

Comment 7 2017-01-19 07:17:15 PST

Comment on attachment 299203 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299203&action=review > Source/WebKit/mac/WebView/WebView.mm:585 > +namespace { I rarely see people using anonymous namespaces in WebKit. I have even seen patches getting rid of them.

Joseph Pecoraro

Comment 8 2017-01-19 11:21:21 PST

> Why just this? There are lots of places we have namespace WebKit in > WebKit1. > I rarely see people using anonymous namespaces in WebKit. I have even seen > patches getting rid of them. This came up as a late review comment in bug 161746. Since it was trivial to address I put a patch up, but based on feedback I'm going to r- for now.

Joseph Pecoraro

Comment 9 2017-01-23 16:47:10 PST

I'm going to close this. I don't know of any real issue here.

Note You need to log in before you can comment on or make changes to this bug.