Bug 167174 – REGRESSION(r206156): Animated images are repeated one extra iteration than the value which is saved in the image file

• Component: Images
• Status: RESOLVED FIXED

[Said Abou-Hallawa]

Created attachment 299180 [details]
red-green-blue-repeat-2.gif

Open the attached files:

1. red-green-blue-repeat-1.gif: loopCount == 1. The image should be animated only once.
2. red-green-blue-repeat-2.gif: loopCount == 2. The image should be animated twice.

RESULT: All images are animated one extra iteration than what it should do.

NOTICE: This regression affects the case where loopCount == 1 or the case when it is missing from the file. For the cases loopCount > 1, the bug did exist before this regression.

[Said Abou-Hallawa]

Created attachment 299181 [details]
red-green-blue-repeat-1.gif

[Said Abou-Hallawa]

Created attachment 299187 [details]
Patch

[Said Abou-Hallawa]

Working on a layout test.

[Build Bot]

Comment on attachment 299187 [details]
Patch

Attachment 299187 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2911712

New failing tests:
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html

[Build Bot]

Created attachment 299196 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Simon Fraser (smfr)]

Comment on attachment 299187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299187&action=review

> Source/WebCore/ChangeLog:10
> +        all other cases. Having repetitionCount() returns zero for loopCount = 1

"Having repetitionCount() return zero"

> Source/WebCore/ChangeLog:12
> +        breaks the animation loop after one iteration. But it was wrong for all

"break"

[Simon Fraser (smfr)]

Comment on attachment 299187 [details]
Patch

Can we test this?

[Said Abou-Hallawa]

Created attachment 299258 [details]
Patch

[Said Abou-Hallawa]

Created attachment 299260 [details]
Patch

[Said Abou-Hallawa]

Created attachment 299281 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/30107642>

[Said Abou-Hallawa]

Comment on attachment 299281 [details]
Patch

The layout test is cleaned a little.

[Said Abou-Hallawa]

Created attachment 299291 [details]
Patch

[Said Abou-Hallawa]

Created attachment 299296 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 299296 [details]
Patch

Using <h2> in the layout test caused it to fail on ios-simulator. Changing it to <p> seems to fix the issue locally.

[WebKit Commit Bot]

Comment on attachment 299296 [details]
Patch

Clearing flags on attachment: 299296

Committed r210951: <http://trac.webkit.org/changeset/210951>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.