Summary: | REGRESSION(r206156): Animated images are repeated one extra iteration than the value which is saved in the image file | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||||||||||
Component: | Images | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, rniwa, simon.fraser, thorton, webkit-bug-importer | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
Attachments: |
|
Created attachment 299181 [details]
red-green-blue-repeat-1.gif
Created attachment 299187 [details]
Patch
Working on a layout test. Comment on attachment 299187 [details] Patch Attachment 299187 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2911712 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html Created attachment 299196 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 299187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299187&action=review > Source/WebCore/ChangeLog:10 > + all other cases. Having repetitionCount() returns zero for loopCount = 1 "Having repetitionCount() return zero" > Source/WebCore/ChangeLog:12 > + breaks the animation loop after one iteration. But it was wrong for all "break" Comment on attachment 299187 [details]
Patch
Can we test this?
Created attachment 299258 [details]
Patch
Created attachment 299260 [details]
Patch
Created attachment 299281 [details]
Patch
Comment on attachment 299281 [details]
Patch
The layout test is cleaned a little.
Created attachment 299291 [details]
Patch
Created attachment 299296 [details]
Patch
Comment on attachment 299296 [details]
Patch
Using <h2> in the layout test caused it to fail on ios-simulator. Changing it to <p> seems to fix the issue locally.
Comment on attachment 299296 [details] Patch Clearing flags on attachment: 299296 Committed r210951: <http://trac.webkit.org/changeset/210951> All reviewed patches have been landed. Closing bug. |
Created attachment 299180 [details] red-green-blue-repeat-2.gif Open the attached files: 1. red-green-blue-repeat-1.gif: loopCount == 1. The image should be animated only once. 2. red-green-blue-repeat-2.gif: loopCount == 2. The image should be animated twice. RESULT: All images are animated one extra iteration than what it should do. NOTICE: This regression affects the case where loopCount == 1 or the case when it is missing from the file. For the cases loopCount > 1, the bug did exist before this regression.