Bug 167164

Summary: check-webkit-style does not work with files being added with a property change and svn 1.9
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: REOPENED    
Severity: Normal CC: buildbot, commit-queue, dbates, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=166948
https://bugs.webkit.org/show_bug.cgi?id=167167
https://bugs.webkit.org/show_bug.cgi?id=174551
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2017-01-18 10:08:12 PST
check-webkit-style will output error messages when a file is added and it's properties are changed in svn 1.9.
Attachments
Patch (4.36 KB, patch)
2017-01-18 14:29 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.49 KB, patch)
2017-03-21 12:43 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-01-18 10:10:05 PST
<rdar://problem/30077060>
Jonathan Bedard
Comment 2 2017-01-18 12:14:30 PST
This error should also occur when simply changing a file's properties, but there is another bug in svn-create-patch, so this issue will only reproduce if a file is both changed and it's properties are changed. Bug 167167 tracks this issue.
Jonathan Bedard
Comment 3 2017-01-18 14:29:49 PST
Created attachment 299183 [details] Patch
WebKit Commit Bot
Comment 4 2017-01-18 14:32:01 PST
Attachment 299183 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py:144: trailing whitespace [pep8/W291] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py:146: trailing whitespace [pep8/W291] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jonathan Bedard
Comment 5 2017-01-18 15:28:42 PST
(In reply to comment #4) > Attachment 299183 [details] did not pass style-queue: > > > ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py:144: > trailing whitespace [pep8/W291] [5] > ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py:146: > trailing whitespace [pep8/W291] [5] > Total errors found: 2 in 3 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. These are a unique case for check-webkit-style. They are referencing style errors in strings which are representing patches. Bug 167181 tracks this.
Jonathan Bedard
Comment 6 2017-03-21 12:43:52 PDT
Created attachment 305013 [details] Patch
Build Bot
Comment 7 2017-03-22 02:31:13 PDT
Attachment 305013 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py:144: trailing whitespace [pep8/W291] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py:146: trailing whitespace [pep8/W291] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jonathan Bedard
Comment 8 2017-07-17 10:21:54 PDT
Comment on attachment 305013 [details] Patch Sam has a better fix for this issue in <https://bugs.webkit.org/show_bug.cgi?id=174551>
Jonathan Bedard
Comment 9 2017-07-17 10:23:04 PDT
Resolved in <https://trac.webkit.org/changeset/219540/webkit>.
Jonathan Bedard
Comment 10 2017-07-17 11:01:34 PDT
I had initially tested this incorrectly. Sam's fix did not address this issue.
Note You need to log in before you can comment on or make changes to this bug.