Bug 167160

Summary: [Modern Media Controls] Hiding controls, changing their width and showing them again shows an incorrect layout
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-elcapitan
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch for landing none

Description Antoine Quint 2017-01-18 06:43:18 PST
Since layout of inline media controls on macOS only happen when the controls bar is visible, changing the width of inline media controls when controls are invisible, and then showing them again yields and incorrect layout.
Comment 1 Antoine Quint 2017-01-18 06:43:46 PST
<rdar://problem/29612318>
Comment 2 Antoine Quint 2017-01-18 06:48:29 PST
Created attachment 299140 [details]
Patch
Comment 3 Build Bot 2017-01-18 07:48:25 PST
Comment on attachment 299140 [details]
Patch

Attachment 299140 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2909831

New failing tests:
fast/hidpi/video-controls-in-hidpi.html
Comment 4 Build Bot 2017-01-18 07:48:28 PST
Created attachment 299144 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-01-18 08:02:05 PST
Comment on attachment 299140 [details]
Patch

Attachment 299140 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2909843

New failing tests:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-resize-with-hidden-controls-bar.html
Comment 6 Build Bot 2017-01-18 08:02:07 PST
Created attachment 299145 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 7 Antoine Quint 2017-01-26 06:22:41 PST
Created attachment 299805 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2017-01-26 06:59:29 PST
Comment on attachment 299805 [details]
Patch for landing

Clearing flags on attachment: 299805

Committed r211209: <http://trac.webkit.org/changeset/211209>
Comment 9 WebKit Commit Bot 2017-01-26 06:59:33 PST
All reviewed patches have been landed.  Closing bug.