Bug 167134

Summary:

Pointer lock events should be delivered directly to the target element

Product:

WebKit

Reporter:

Jeremy Jones <jeremyj-wk>

Component:

WebCore Misc.

Assignee:

Jeremy Jones <jeremyj-wk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, jer.noble, jonlee, ryanhaddad, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=167511

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Jeremy Jones

Reported 2017-01-17 13:08:03 PST

Pointer lock events should be delivered directly to the target element

Attachments
Patch (8.28 KB, patch) 2017-01-17 13:16 PST, Jeremy Jones	no flags	Details Formatted Diff Diff
Patch (12.16 KB, patch) 2017-01-25 19:09 PST, Jeremy Jones	no flags	Details Formatted Diff Diff
Patch (12.78 KB, patch) 2017-02-02 16:15 PST, Jeremy Jones	no flags	Details Formatted Diff Diff
Patch (12.84 KB, patch) 2017-02-02 16:19 PST, Jeremy Jones	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jeremy Jones

Comment 1 2017-01-17 13:08:39 PST

rdar://problem/30058933

Jeremy Jones

Comment 2 2017-01-17 13:16:36 PST

Created attachment 299055 [details] Patch

Jon Lee

Comment 3 2017-01-25 17:36:55 PST

Comment on attachment 299055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299055&action=review > LayoutTests/pointer-lock/mouse-event-delivery.html:50 > + window.eventSender.mouseMoveTo(20,20); why does this need to be added?

Jeremy Jones

Comment 4 2017-01-25 19:09:38 PST

Created attachment 299785 [details] Patch

Jeremy Jones

Comment 5 2017-01-25 23:30:45 PST

(In reply to comment #3) > Comment on attachment 299055 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299055&action=review > > > LayoutTests/pointer-lock/mouse-event-delivery.html:50 > > + window.eventSender.mouseMoveTo(20,20); > > why does this need to be added? The pointer-lock/mouse-event-delivery.html test is modified to explicitly move the mouse pointer to a valid location before sending mouse actions. Without this, the test infrastructure doesn't know that the pointer is over the web view and doesn't deliver events.

Jeremy Jones

Comment 6 2017-01-26 11:13:30 PST

*** Bug 167133 has been marked as a duplicate of this bug. ***

WebKit Commit Bot

Comment 7 2017-01-26 15:49:13 PST

Comment on attachment 299785 [details] Patch Clearing flags on attachment: 299785 Committed r211235: <http://trac.webkit.org/changeset/211235>

WebKit Commit Bot

Comment 8 2017-01-26 15:49:18 PST

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 9 2017-01-30 10:20:35 PST

*** Bug 167511 has been marked as a duplicate of this bug. ***