Summary: | Web Inspector: Tooltip text should not end in a period | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Matt Baker
2017-01-17 12:00:47 PST
Created attachment 299057 [details]
Patch
Comment on attachment 299057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299057&action=review I think the intent of this bug was a little vague. I tried to add some more specific pointers. Should be easy to fix up. > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:270 > +localizedStrings["Edit cubic-bezier"] = "Edit cubic-bezier"; Edit 'cubic-bezier' function > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:271 > +localizedStrings["Edit spring"] = "Edit spring"; Edit 'spring' function > Source/WebInspectorUI/UserInterface/Models/DatabaseObject.js:-74 > - errorCallback(WebInspector.UIString("Database no longer has expected version.")); I don't think these strings should be changed if they are simply UIStrings for error messages. Do these have tooltips as well? I am mainly concerned about button/action labels. These are neither. > Source/WebInspectorUI/UserInterface/Models/Resource.js:657 > if (this._failed) Ditto. > Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:-97 > - error: WebInspector.UIString("An error occurred trying to load the resource."), Ditto. > Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:-109 > - return Promise.resolve({error: WebInspector.UIString("An error occurred trying to load the resource.")}); Ditto. > Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js:117 > + message = WebInspector.UIString("Unexpected database version"); Ditto. > Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js:112 > + this._messageTextViewElement = WebInspector.createMessageTextView(WebInspector.UIString("Error reading â%sâ table").format(this.representedObject.name), true); Ditto > Source/WebInspectorUI/UserInterface/Views/DatabaseUserQuerySuccessView.js:-41 > - this.resultElement.textContent = WebInspector.UIString("Query returned no results."); Ditto. > Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js:-40 > - this._swatchElement.title = WebInspector.UIString("Click to open a cubic-bezier editor."); I prefer: Edit 'cubic-bezier' function Edit 'spring' function Edit custom gradient > Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:-113 > - this._contentError(WebInspector.UIString("An error occurred trying to load the resource.")); Ditto. > Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js:-307 > - descriptionElement.textContent = WebInspector.UIString("Resource failed to load."); Ditto. > Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js:62 > + let addGlyphElement = useSVGSymbol("Images/Plus13.svg", "visual-style-selector-section-add-rule", WebInspector.UIString("New Rule")); "Add new rule" > Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.js:227 > + this._checkboxElement.title = WebInspector.UIString("Disable Rule"); How about: "Comment out rule" / "Uncomment rule" Created attachment 300229 [details]
Patch
Comment on attachment 300229 [details]
Patch
r=me, thanks Devin!
Comment on attachment 300229 [details] Patch Rejecting attachment 300229 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 300229, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: hing file Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.js patching file Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyNameInput.js patching file Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js patching file Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brian Burg']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2981889 Created attachment 300284 [details]
Patch
Comment on attachment 300284 [details] Patch Clearing flags on attachment: 300284 Committed r211462: <http://trac.webkit.org/changeset/211462> All reviewed patches have been landed. Closing bug. |