Bug 167124

Summary: Document::securityOrigin() should return a reference.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for EWS
none
Patch for EWS II
none
Patch for EWS III
buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan
none
Patch
none
Patch
sam: review+
Patch for landing
none
Archive of layout-test-results from ews100 for mac-elcapitan none

Description Andreas Kling 2017-01-17 10:21:50 PST
Excluding a tiny time window during construction, Document always has a SecurityOrigin.
Let's make securityOrigin() return a reference.
Comment 1 Andreas Kling 2017-01-17 10:27:53 PST
Created attachment 299041 [details]
Patch for EWS
Comment 2 WebKit Commit Bot 2017-01-17 10:31:00 PST
Attachment 299041 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm:102:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2017-01-17 17:01:35 PST
Created attachment 299088 [details]
Patch for EWS II
Comment 4 WebKit Commit Bot 2017-01-17 17:03:22 PST
Attachment 299088 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm:102:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 92 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andreas Kling 2017-01-17 17:46:50 PST
Created attachment 299093 [details]
Patch for EWS III
Comment 6 Build Bot 2017-01-17 18:58:56 PST
Comment on attachment 299093 [details]
Patch for EWS III

Attachment 299093 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2906889

New failing tests:
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
Comment 7 Build Bot 2017-01-17 18:59:00 PST
Created attachment 299108 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Andreas Kling 2017-01-17 22:34:34 PST
Created attachment 299120 [details]
Patch
Comment 9 Andreas Kling 2017-01-18 07:41:16 PST
Created attachment 299143 [details]
Patch
Comment 10 Andreas Kling 2017-01-18 09:25:49 PST
Created attachment 299149 [details]
Patch for landing
Comment 11 Build Bot 2017-01-18 10:44:46 PST
Comment on attachment 299149 [details]
Patch for landing

Attachment 299149 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2910422

New failing tests:
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
Comment 12 Build Bot 2017-01-18 10:44:48 PST
Created attachment 299156 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 13 Andreas Kling 2017-01-18 11:11:16 PST
Comment on attachment 299149 [details]
Patch for landing

Test appears to be EWS hiccup
Comment 14 WebKit Commit Bot 2017-01-18 11:37:01 PST
Comment on attachment 299149 [details]
Patch for landing

Clearing flags on attachment: 299149

Committed r210859: <http://trac.webkit.org/changeset/210859>
Comment 15 WebKit Commit Bot 2017-01-18 11:37:06 PST
All reviewed patches have been landed.  Closing bug.
Comment 16 Radar WebKit Bug Importer 2017-05-04 18:03:30 PDT
<rdar://problem/32005222>