Summary: | Document::securityOrigin() should return a reference. | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||||||||
Component: | WebCore Misc. | Assignee: | Andreas Kling <kling> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, rniwa, webkit-bug-importer | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Attachments: |
|
Description
Andreas Kling
2017-01-17 10:21:50 PST
Created attachment 299041 [details]
Patch for EWS
Attachment 299041 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 90 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 299088 [details]
Patch for EWS II
Attachment 299088 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/Plugins/WebPluginContainerCheck.mm:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 92 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 299093 [details]
Patch for EWS III
Comment on attachment 299093 [details] Patch for EWS III Attachment 299093 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2906889 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html Created attachment 299108 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 299120 [details]
Patch
Created attachment 299143 [details]
Patch
Created attachment 299149 [details]
Patch for landing
Comment on attachment 299149 [details] Patch for landing Attachment 299149 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2910422 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html Created attachment 299156 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 299149 [details]
Patch for landing
Test appears to be EWS hiccup
Comment on attachment 299149 [details] Patch for landing Clearing flags on attachment: 299149 Committed r210859: <http://trac.webkit.org/changeset/210859> All reviewed patches have been landed. Closing bug. |