Bug 167107

Summary:

[GTK] [MSE] Turn MSE on by default

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

WebKitGTK

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, calvaris, cgarcia, commit-queue, cturner, dyskette, eocanha, janousek.jiri, mcatanzaro, zan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

167108, 99065, 165394, 167120

Bug Blocks:

131313

Attachments:

Description	Flags
Patch	none

Carlos Alberto Lopez Perez

Reported 2017-01-16 18:54:56 PST

All WebKit ports are enabling MSE by default since 2014. See bug 131313. MSE is needed (among other things) for having 1080p (or superior quality) video on Youtube. With WebKitGTK+ trunk: $ Tools/Scripts/run-minibrowser --gtk --release https://www.youtube.com/watch?v=iNJdPyoqt8U (only 720p available) $ Tools/Scripts/run-minibrowser --gtk --release --enable-mediasource=true https://www.youtube.com/watch?v=iNJdPyoqt8U (1080p and 4k available) Is there any reason why we are still not shipping this by default??

Attachments
Patch (3.70 KB, patch) 2017-12-01 09:53 PST, Michael Catanzaro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2017-01-16 20:00:45 PST

(Do we need WebM support before we can turn it on, or does YouTube gracefully degrade to non-MSE when encumbered codecs are unavailable?)

Carlos Alberto Lopez Perez

Comment 2 2017-01-17 09:37:13 PST

(In reply to comment #1) > (Do we need WebM support before we can turn it on, or does YouTube > gracefully degrade to non-MSE when encumbered codecs are unavailable?) No, it just crashes ;) See bug 167120

Michael Catanzaro

Comment 3 2017-07-25 13:28:29 PDT

(In reply to Carlos Alberto Lopez Perez from comment #0) > All WebKit ports are enabling MSE by default since 2014. See bug 131313. > > MSE is needed (among other things) for having 1080p (or superior quality) > video on Youtube. On Fedora, we are currently limited to 360p quality video on YouTube. MSE is required to get 480p, 720p and 1080p when H.264 is not supported. On platforms which include H.264 support, the max is indeed 720p without MSE, so the need for MSE is much less urgent.

Carlos Alberto Lopez Perez

Comment 4 2017-12-01 05:30:37 PST

*** Bug 180233 has been marked as a duplicate of this bug. ***

Michael Catanzaro

Comment 5 2017-12-01 09:53:11 PST

Created attachment 328109 [details] Patch

WebKit Commit Bot

Comment 6 2017-12-01 10:33:20 PST

Comment on attachment 328109 [details] Patch Clearing flags on attachment: 328109 Committed r225400: <https://trac.webkit.org/changeset/225400>

WebKit Commit Bot

Comment 7 2017-12-01 10:33:21 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.