Bug 167104

Summary: [QuickLook] QLPreviewConverter should be owned by its delegate
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, dbates, ddkilzer, japhet, kling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andy Estes 2017-01-16 18:36:52 PST 
[QuickLook] QLPreviewConverter should be owned by its delegate
Comment 1 Andy Estes 2017-01-16 18:46:23 PST 
Created attachment 299007 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-16 18:48:18 PST 
Attachment 299007 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/ios/QuickLook.mm:331:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:356:  Extra space in capture list.  [whitespace/brackets] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2017-01-16 18:59:25 PST 
Comment on attachment 299007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299007&action=review

> Source/WebCore/loader/ios/QuickLook.mm:183
> +    static auto& emptyClient = adoptRef(*new QuickLookHandleClient()).leakRef();

It would be nice to use NeverDestroyed here to avoid the permanent heap allocation.
Comment 4 Andy Estes 2017-01-16 19:17:13 PST 
Created attachment 299012 [details]
Patch
Comment 5 WebKit Commit Bot 2017-01-16 19:55:06 PST 
Comment on attachment 299012 [details]
Patch

Clearing flags on attachment: 299012

Committed r210796: <http://trac.webkit.org/changeset/210796>
Comment 6 WebKit Commit Bot 2017-01-16 19:55:11 PST 
All reviewed patches have been landed.  Closing bug.