Bug 167089

Summary:

[SOUP] Accept-language could be set twice in a row for the default context

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, mcatanzaro, zan

Priority:

Keywords:

Soup

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zan: review+

Description Carlos Garcia Campos 2017-01-16 03:37:53 PST

If NetworkStorageSession doesn't have a SoupNetworkSession yet, we are creating it only to set the languages. Since we already set the global value, the languages will be set when the  SoupNetworkSession is created later. This is not a big deal for the language property, but it will be for proxies after bug #128674.

Comment 1 Carlos Garcia Campos 2017-01-16 03:43:47 PST

Created attachment 298950 [details]
Patch

Comment 2 Carlos Garcia Campos 2017-01-16 03:51:32 PST

Committed r210786: <http://trac.webkit.org/changeset/210786>

Comment 3 Michael Catanzaro 2017-01-16 07:35:08 PST

It's way too much typing to get the SoupNetworkSession in the normal case where you don't care if you create it or not. :(