Bug 167089

Summary: [SOUP] Accept-language could be set twice in a row for the default context
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, zan
Priority: P2 Keywords: Soup
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2017-01-16 03:37:53 PST
If NetworkStorageSession doesn't have a SoupNetworkSession yet, we are creating it only to set the languages. Since we already set the global value, the languages will be set when the SoupNetworkSession is created later. This is not a big deal for the language property, but it will be for proxies after bug #128674.
Attachments
Patch (12.01 KB, patch)
2017-01-16 03:43 PST, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-01-16 03:43:47 PST
Created attachment 298950 [details] Patch
Carlos Garcia Campos
Comment 2 2017-01-16 03:51:32 PST
Committed r210786: <http://trac.webkit.org/changeset/210786>
Michael Catanzaro
Comment 3 2017-01-16 07:35:08 PST
It's way too much typing to get the SoupNetworkSession in the normal case where you don't care if you create it or not. :(
Note You need to log in before you can comment on or make changes to this bug.