Bug 167055

Summary:

Remove PassRefPtr from "loader" directory of WebCore

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, ossy, pvollan, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

167771

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	achristensen: review+, commit-queue: commit-queue-
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan	none

Darin Adler

Reported 2017-01-14 13:23:41 PST

Remove PassRefPtr from "loader" directory of WebCore

Attachments
Patch (599.08 KB, patch) 2017-01-14 16:34 PST, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.28 MB, application/zip) 2017-01-14 18:12 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (2.06 MB, application/zip) 2017-01-14 18:22 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.81 MB, application/zip) 2017-01-14 18:31 PST, Build Bot	no flags	Details
Patch (605.80 KB, patch) 2017-01-14 21:47 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (618.86 KB, patch) 2017-01-14 22:32 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (643.67 KB, patch) 2017-01-15 11:08 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (656.69 KB, patch) 2017-01-15 12:18 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (656.36 KB, patch) 2017-01-15 12:28 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (662.51 KB, patch) 2017-01-15 13:54 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (663.05 KB, patch) 2017-01-15 19:58 PST, Darin Adler	achristensen: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch (660.68 KB, patch) 2017-01-17 19:43 PST, Darin Adler	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (775.02 KB, application/zip) 2017-01-17 20:58 PST, Build Bot	no flags	Details
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2017-01-14 16:34:44 PST

Created attachment 298867 [details] Patch

WebKit Commit Bot

Comment 2 2017-01-14 16:37:20 PST

Attachment 298867 [details] did not pass style-queue: ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 6 in 124 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2017-01-14 18:12:32 PST

Comment on attachment 298867 [details] Patch Attachment 298867 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2890437 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2017-01-14 18:12:34 PST

Created attachment 298869 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-01-14 18:22:48 PST

Comment on attachment 298867 [details] Patch Attachment 298867 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2890446 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2017-01-14 18:22:51 PST

Created attachment 298870 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-01-14 18:31:28 PST

Comment on attachment 298867 [details] Patch Attachment 298867 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2890565 New failing tests: http/tests/appcache/different-origin-manifest.html http/tests/appcache/cyrillic-uri.html http/tests/appcache/origin-usage.html http/tests/appcache/history-test.html http/tests/appcache/crash-when-navigating-away-then-back.html http/tests/appcache/simple-video-sync.html http/tests/appcache/max-size.html http/tests/appcache/origin-delete.html http/tests/appcache/top-frame-1.html http/tests/appcache/whitelist-wildcard.html http/tests/ssl/verify-ssl-enabled.php http/tests/appcache/main-resource-fallback-for-network-error-crash.html http/tests/appcache/origin-quota-continued-download.html http/tests/appcache/progress-counter.html http/tests/appcache/reload.html http/tests/appcache/foreign-iframe-main.html http/tests/appcache/main-resource-redirect.html http/tests/appcache/local-content.html http/tests/appcache/top-frame-3.html http/tests/appcache/resource-redirect-2.html http/tests/appcache/wrong-signature-2.html http/tests/appcache/manifest-parsing.html http/tests/appcache/update-cache.html http/tests/appcache/identifier-test.html http/tests/appcache/offline-access.html http/tests/security/cross-origin-appcache.html http/tests/appcache/x-frame-options-prevents-framing.php

Build Bot

Comment 8 2017-01-14 18:31:31 PST

Created attachment 298871 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Darin Adler

Comment 9 2017-01-14 21:47:45 PST

Created attachment 298885 [details] Patch

WebKit Commit Bot

Comment 10 2017-01-14 21:49:51 PST

Attachment 298885 [details] did not pass style-queue: ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 6 in 125 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 11 2017-01-14 22:32:29 PST

Created attachment 298888 [details] Patch

WebKit Commit Bot

Comment 12 2017-01-14 22:35:17 PST

Attachment 298888 [details] did not pass style-queue: ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 6 in 129 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 13 2017-01-15 11:08:20 PST

Created attachment 298905 [details] Patch

WebKit Commit Bot

Comment 14 2017-01-15 11:10:56 PST

Attachment 298905 [details] did not pass style-queue: ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 6 in 137 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 15 2017-01-15 12:05:54 PST

Darn, still not compiling on iOS. But I am getting closer. Tests all passing, all platforms compiling except for iOS and maybe Windows.

Darin Adler

Comment 16 2017-01-15 12:18:32 PST

Created attachment 298919 [details] Patch

Darin Adler

Comment 17 2017-01-15 12:28:06 PST

Created attachment 298926 [details] Patch

WebKit Commit Bot

Comment 18 2017-01-15 12:30:17 PST

Attachment 298926 [details] did not pass style-queue: ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 6 in 140 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 19 2017-01-15 13:54:00 PST

Created attachment 298930 [details] Patch

WebKit Commit Bot

Comment 20 2017-01-15 13:55:46 PST

Attachment 298930 [details] did not pass style-queue: ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 6 in 142 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 21 2017-01-15 19:58:06 PST

Created attachment 298935 [details] Patch

WebKit Commit Bot

Comment 22 2017-01-15 19:59:37 PST

Attachment 298935 [details] did not pass style-queue: ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 6 in 143 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 23 2017-01-15 23:59:50 PST

OK, all green now. Review time.

WebKit Commit Bot

Comment 24 2017-01-17 16:27:05 PST

Comment on attachment 298935 [details] Patch Rejecting attachment 298935 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 298935, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: file Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp patching file Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm Hunk #1 succeeded at 468 (offset 1 line). patching file Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm patching file Source/WebKit2/WebProcess/WebProcess.cpp patching file Source/WebKit2/WebProcess/WebProcess.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2906354

Darin Adler

Comment 25 2017-01-17 19:43:46 PST

Created attachment 299112 [details] Patch

WebKit Commit Bot

Comment 26 2017-01-17 19:46:25 PST

Attachment 299112 [details] did not pass style-queue: ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:60: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:61: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:62: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:63: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/loader/appcache/ApplicationCacheHost.h:64: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 6 in 141 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 27 2017-01-17 20:58:38 PST

Comment on attachment 299112 [details] Patch Attachment 299112 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2907346 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html

Build Bot

Comment 28 2017-01-17 20:58:41 PST

Created attachment 299116 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Darin Adler

Comment 29 2017-01-17 21:18:34 PST

Committed r210845: <http://trac.webkit.org/changeset/210845>

Csaba Osztrogonác

Comment 30 2017-01-18 01:19:51 PST

Comment on attachment 299112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299112&action=review > Source/WebCore/loader/DocumentLoader.cpp:866 > + if (m_archive && m_archive->shouldOverrideBaseURL()) This change broke the !ENABLE(MHTML) build, because m_archive is declared inside ENABLE(WEB_ARCHIV) || ENABLE(MHTML) guard. > Source/WebCore/loader/DocumentLoader.cpp:883 > + if (m_archive && m_archive->shouldUseMainResourceEncoding()) ditto

Csaba Osztrogonác

Comment 31 2017-01-18 02:29:17 PST

(In reply to comment #29) > Committed r210845: <http://trac.webkit.org/changeset/210845> FYI Alex, it broke the WinCairo build: C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\WebKit\win\WebCoreSupport\WebFrameLoaderClient.h(77): error C3668: 'WebFrameLoaderClient::shouldCacheResponse': method with override specifier 'override' did not override any base class methods ninja: build stopped: subcommand failed.

Alex Christensen

Comment 32 2017-01-18 12:29:28 PST

https://trac.webkit.org/changeset/210863

Note You need to log in before you can comment on or make changes to this bug.