Bug 167039 – [WebIDL] Remove custom bindings for HTMLInputElement, HTMLFrameElement, HTMLMediaElement and HTMLOptionsCollection

• Component: New Bugs
• Status: RESOLVED FIXED

[Sam Weinig]

[WebIDL] Remove custom bindings for HTMLInputElement, HTMLFrameElement, HTMLMediaElement and HTMLOptionsCollection

[Sam Weinig]

Created attachment 298815 [details]
Patch

[Build Bot]

Comment on attachment 298815 [details]
Patch

Attachment 298815 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2885302

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298820 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298815 [details]
Patch

Attachment 298815 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2885326

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298821 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298815 [details]
Patch

Attachment 298815 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2885336

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298822 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298815 [details]
Patch

Attachment 298815 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2885354

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298824 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Created attachment 298826 [details]
Patch

[Build Bot]

Comment on attachment 298826 [details]
Patch

Attachment 298826 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2885661

New failing tests:
fast/dom/HTMLSelectElement/select-selectedIndex.html
inspector/model/remote-object-get-properties.html
fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html
fast/forms/selection-functions.html
fast/forms/selection-wrongtype.html

[Build Bot]

Created attachment 298836 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298826 [details]
Patch

Attachment 298826 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2885662

New failing tests:
fast/dom/HTMLSelectElement/select-selectedIndex.html
inspector/model/remote-object-get-properties.html
fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html
fast/forms/selection-functions.html
fast/forms/selection-wrongtype.html

[Build Bot]

Created attachment 298837 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298826 [details]
Patch

Attachment 298826 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2885676

New failing tests:
fast/dom/HTMLSelectElement/select-selectedIndex.html
inspector/model/remote-object-get-properties.html
fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html
fast/forms/selection-functions.html
fast/forms/selection-wrongtype.html

[Build Bot]

Created attachment 298839 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298826 [details]
Patch

Attachment 298826 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2885665

New failing tests:
fast/dom/HTMLSelectElement/select-selectedIndex.html
fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html
fast/forms/selection-functions.html
fast/forms/selection-wrongtype.html

[Build Bot]

Created attachment 298840 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Created attachment 298856 [details]
Patch

[Sam Weinig]

Created attachment 298857 [details]
Patch

[Sam Weinig]

Ready for review.

[Darin Adler]

Comment on attachment 298857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298857&action=review

> Source/WebCore/html/HTMLSelectElement.cpp:466
> +        document().addConsoleMessage(MessageSource::Other, MessageLevel::Warning, String::format("Blocked attempt to expand the option list to %u items. The maximum number of items allowed is %u.", newLength, maxSelectItems));

We need that makeString thing so we don’t use String::format.

[WebKit Commit Bot]

Comment on attachment 298857 [details]
Patch

Clearing flags on attachment: 298857

Committed r210780: <http://trac.webkit.org/changeset/210780>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.