Bug 167025

Summary:

Web Inspector: Settings tab is restored when reopening inspector

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Devin Rousso

Reported 2017-01-13 15:42:37 PST

* Steps to reproduce 1. Open WebInspector 2. Select Settings tab (gear icon on far right of tab bar) 3. Close WebInspector 4. Open WebInspector * Expected Tab previously selected before Settings tab is shown. * Actual The Settings tab is shown.

Attachments
Patch (1.72 KB, patch) 2017-01-13 20:10 PST, Devin Rousso	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Blaze Burg

Comment 1 2017-01-13 15:52:07 PST

Unsure why one way is better than the other. Can you elaborate?

Radar WebKit Bug Importer

Comment 2 2017-01-13 15:52:57 PST

<rdar://problem/30022133>

Devin Rousso

Comment 3 2017-01-13 20:04:24 PST

(In reply to comment #1) > Unsure why one way is better than the other. Can you elaborate? I think that since settings are something that usually won't be changed often, to have the inspector window reopen to the settings view seems weird. I'd rather the settings view be sorta "transient" in that it acts as if it is never shown. What I mean by that is that clicking the gear icon will open the settings view, but it won't trigger the saving of the newly active tab, so reopening the inspector will go back to the previous view.

Devin Rousso

Comment 4 2017-01-13 20:10:41 PST

Created attachment 298842 [details] Patch

Matt Baker

Comment 5 2017-01-13 22:24:28 PST

(In reply to comment #3) > (In reply to comment #1) > > Unsure why one way is better than the other. Can you elaborate? > > I think that since settings are something that usually won't be changed > often, to have the inspector window reopen to the settings view seems weird. > I'd rather the settings view be sorta "transient" in that it acts as if it > is never shown. What I mean by that is that clicking the gear icon will > open the settings view, but it won't trigger the saving of the newly active > tab, so reopening the inspector will go back to the previous view. I agree, "transient" is a good way to think about it.

WebKit Commit Bot

Comment 6 2017-01-13 23:10:56 PST

Comment on attachment 298842 [details] Patch Clearing flags on attachment: 298842 Committed r210764: <http://trac.webkit.org/changeset/210764>

WebKit Commit Bot

Comment 7 2017-01-13 23:11:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.