Bug 167025 – Web Inspector: Settings tab is restored when reopening inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

* Steps to reproduce

1. Open WebInspector
2. Select Settings tab (gear icon on far right of tab bar)
3. Close WebInspector
4. Open WebInspector


* Expected

Tab previously selected before Settings tab is shown.


* Actual

The Settings tab is shown.

[Blaze Burg]

Unsure why one way is better than the other. Can you elaborate?

[Radar WebKit Bug Importer]

<rdar://problem/30022133>

[Devin Rousso]

(In reply to comment #1)
> Unsure why one way is better than the other. Can you elaborate?

I think that since settings are something that usually won't be changed often, to have the inspector window reopen to the settings view seems weird.  I'd rather the settings view be sorta "transient" in that it acts as if it is never shown.  What I mean by that is that clicking the gear icon will open the settings view, but it won't trigger the saving of the newly active tab, so reopening the inspector will go back to the previous view.

[Devin Rousso]

Created attachment 298842 [details]
Patch

[Matt Baker]

(In reply to comment #3)
> (In reply to comment #1)
> > Unsure why one way is better than the other. Can you elaborate?
> 
> I think that since settings are something that usually won't be changed
> often, to have the inspector window reopen to the settings view seems weird.
> I'd rather the settings view be sorta "transient" in that it acts as if it
> is never shown.  What I mean by that is that clicking the gear icon will
> open the settings view, but it won't trigger the saving of the newly active
> tab, so reopening the inspector will go back to the previous view.

I agree, "transient" is a good way to think about it.

[WebKit Commit Bot]

Comment on attachment 298842 [details]
Patch

Clearing flags on attachment: 298842

Committed r210764: <http://trac.webkit.org/changeset/210764>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.