Summary: | Added preprocessor guard for iOS-specific piece of code in GraphicsContext3DOpenGL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Konstantin Tokarev <annulen> | ||||
Component: | WebCore Misc. | Assignee: | Konstantin Tokarev <annulen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, commit-queue, dbates, dino, graouts, kondapallykalyan, noam | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Konstantin Tokarev
2017-01-13 07:52:09 PST
Created attachment 298759 [details]
Patch
Comment on attachment 298759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298759&action=review > Source/WebCore/ChangeLog:8 > + Variable "boundFrameBuffer" is used only in IOS-specific code Oops, will change to iOS before commiting Committed r210731: <http://trac.webkit.org/changeset/210731> Comment on attachment 298759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298759&action=review > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:232 > GLint boundFrameBuffer; > ::glGetIntegerv(GL_FRAMEBUFFER_BINDING, &boundFrameBuffer); Can we move this code into the existing PLATFORM(IOS)-guarded section below or do we need to execute this statement before the glBindFramebufferEXT() calls? Obviously, the benefit of moving this code under the existing PLATFORM(IOS)-guarded code section in this functions is that we can avoid adding another guard. We definitely need to check which frame buffer is bound before binding another one. (In reply to comment #5) > We definitely need to check which frame buffer is bound before binding > another one. I'm blind. |