Bug 166950

Summary: Report post-page load CPU usage using diagnostic logging
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, buildbot, commit-queue, darin, dbates, japhet, kling, koivisto, krollin, ossy, rniwa, sam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=167019
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
none
Patch
none
Patch none

Chris Dumez
Reported 2017-01-11 16:34:54 PST
Report post-page load CPU usage using diagnostic logging.
Attachments
WIP Patch (19.20 KB, patch)
2017-01-11 17:02 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (19.65 KB, patch)
2017-01-12 09:33 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (23.90 KB, patch)
2017-01-12 10:35 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.24 MB, application/zip)
2017-01-12 12:14 PST, Build Bot 		no flags
Details
Patch (24.45 KB, patch)
2017-01-12 16:04 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.53 KB, patch)
2017-01-13 09:31 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-01-11 17:02:52 PST
Created attachment 298634 [details] WIP Patch
Chris Dumez
Comment 2 2017-01-12 09:30:12 PST
<rdar://problem/29964139>
Chris Dumez
Comment 3 2017-01-12 09:33:29 PST
Created attachment 298690 [details] WIP Patch
Chris Dumez
Comment 4 2017-01-12 10:35:22 PST
Created attachment 298695 [details] Patch
Build Bot
Comment 5 2017-01-12 12:14:24 PST
Comment on attachment 298695 [details] Patch Attachment 298695 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2878389 New failing tests: fast/mediastream/MediaStream-video-element-track-stop.html
Build Bot
Comment 6 2017-01-12 12:14:30 PST
Created attachment 298705 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Keith Rollin
Comment 7 2017-01-12 12:39:35 PST
There might be a problem with the Timer if the user navigates away from the page before it triggers, and the next page takes a long time to load such that we now exceed the trigger time.
Chris Dumez
Comment 8 2017-01-12 16:04:02 PST
Created attachment 298725 [details] Patch
Chris Dumez
Comment 9 2017-01-12 16:05:28 PST
(In reply to comment #7) > There might be a problem with the Timer if the user navigates away from the > page before it triggers, and the next page takes a long time to load such > that we now exceed the trigger time. Good catch, I now stop the timer on navigating away.
Alex Christensen
Comment 10 2017-01-13 09:25:19 PST
Comment on attachment 298725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298725&action=review > Source/WebCore/loader/FrameLoader.cpp:997 > + page->didStartLoad(); didStartProvisionalLoad?
Chris Dumez
Comment 11 2017-01-13 09:31:12 PST
Created attachment 298763 [details] Patch
Chris Dumez
Comment 12 2017-01-13 09:31:45 PST
(In reply to comment #10) > Comment on attachment 298725 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=298725&action=review > > > Source/WebCore/loader/FrameLoader.cpp:997 > > + page->didStartLoad(); > > didStartProvisionalLoad? Done. Thanks for the review.
Chris Dumez
Comment 13 2017-01-13 09:56:00 PST
Comment on attachment 298763 [details] Patch Clearing flags on attachment: 298763 Committed r210733: <http://trac.webkit.org/changeset/210733>
Chris Dumez
Comment 14 2017-01-13 09:56:06 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 15 2017-01-14 01:39:08 PST
(In reply to comment #13) > Comment on attachment 298763 [details] > Patch > > Clearing flags on attachment: 298763 > > Committed r210733: <http://trac.webkit.org/changeset/210733> It broke the Apple Mac cmake build. https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/11255
Note You need to log in before you can comment on or make changes to this bug.