Bug 166902

Summary: Keyboard accessory bar can appear on top of full-screen video
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, eric.carlson, jeremyj-wk, jer.noble, jonlee, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2017-01-10 12:38:00 PST
Keyboard accessory bar can appear on top of full-screen video
Attachments
Patch (1.96 KB, patch)
2017-01-10 12:38 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-01-10 12:38:08 PST
Created attachment 298500 [details] Patch
Sam Weinig
Comment 2 2017-01-10 13:20:04 PST
Test?
Tim Horton
Comment 3 2017-01-10 13:31:04 PST
Of full-screen window level? Maybe with Jer's new test app?
Tim Horton
Comment 4 2017-01-10 14:08:20 PST
(In reply to comment #3) > Of full-screen window level? Maybe with Jer's new test app? Not sure it's super valuable, though, I will just end up testing that an integer that I set is still the value that I set it to :| Also, the UI test app doesn't seem super fleshed out yet, so it should probably be a layout test (it does seem like we can go full-screen in a layout test) with some UISC glue to check the window level?
Tim Horton
Comment 5 2017-01-10 19:05:10 PST
(In reply to comment #2) > Test? I think not, for now. WebKitTestRunner still doesn't seem to have enough UIKit infrastructure (it's still not a UIApplication) set up to make full-screen actually work (though I just spent far too long trying). I will try again with MobileMiniBrowser, but it's not very scalable (currently have to add new UI for each test).
Simon Fraser (smfr)
Comment 6 2017-01-10 21:06:10 PST
(In reply to comment #5) > (In reply to comment #2) > > Test? > > I think not, for now. WebKitTestRunner still doesn't seem to have enough > UIKit infrastructure (it's still not a UIApplication) iOS uses WebKitTestRunnerApp.app, which is a UIApplication with a root view controller.
Tim Horton
Comment 7 2017-01-10 21:27:10 PST
Hmm, odd. I was getting all manner of bizarre logging to the contrary from UIWindow, but maybe I was doing something wrong.
WebKit Commit Bot
Comment 8 2017-01-12 23:38:00 PST
Comment on attachment 298500 [details] Patch Clearing flags on attachment: 298500 Committed r210727: <http://trac.webkit.org/changeset/210727>
WebKit Commit Bot
Comment 9 2017-01-12 23:38:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.