Bug 166894

Summary: Make Event.initEvent()'s first parameter mandatory
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-01-10 10:42:11 PST
Make Event.initEvent()'s first parameter mandatory.
Attachments
Patch (7.77 KB, patch)
2017-01-10 10:44 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-01-10 10:44:50 PST
Created attachment 298479 [details] Patch
Alex Christensen
Comment 2 2017-01-10 13:44:01 PST
Comment on attachment 298479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298479&action=review > Source/WebCore/ChangeLog:13 > + the specification. However, having the first parameter optional > + makes little sense as it would set the event's type to the string > + "undefined". Also, all the content we found that was broken by making all three mandatory had one parameter indicating the type.
WebKit Commit Bot
Comment 3 2017-01-10 14:00:18 PST
Comment on attachment 298479 [details] Patch Clearing flags on attachment: 298479 Committed r210559: <http://trac.webkit.org/changeset/210559>
WebKit Commit Bot
Comment 4 2017-01-10 14:00:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.