Bug 166839

Summary: macOS does not support php7 for layout tests
Product: WebKit Reporter: Lucas Forschler <lforschler>
Component: Tools / TestsAssignee: Lucas Forschler <lforschler>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, glenn, lforschler, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
v1 patch to add php7 support for macOS.
none
v2, correct style ap: review+

Lucas Forschler
Reported 2017-01-09 05:21:23 PST
Currently, the macOS port uses php5. We should plan for the future and support php7.
Attachments
v1 patch to add php7 support for macOS. (7.55 KB, patch)
2017-01-09 05:35 PST, Lucas Forschler 		no flags
DetailsFormatted DiffDiff
v2, correct style (7.52 KB, patch)
2017-01-09 05:53 PST, Lucas Forschler 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lucas Forschler
Comment 1 2017-01-09 05:22:14 PST
The debian port simply searches for a lib7php, and then uses a different apache config. It seems like extending that for macOS would be simple.
Lucas Forschler
Comment 2 2017-01-09 05:35:28 PST
Created attachment 298347 [details] v1 patch to add php7 support for macOS.
WebKit Commit Bot
Comment 3 2017-01-09 05:37:52 PST
Attachment 298347 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/port/base.py:1190: trailing whitespace [pep8/W291] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Lucas Forschler
Comment 4 2017-01-09 05:53:42 PST
Created attachment 298348 [details] v2, correct style
Alexey Proskuryakov
Comment 5 2017-01-09 09:09:12 PST
Comment on attachment 298348 [details] v2, correct style It's unfortunate that the config had to be duplicated again. I hoped that we could pass an option via command line. Could you land this manually while doing an "svn cp" first, to preserve file history?
Lucas Forschler
Comment 6 2017-01-09 09:41:31 PST
Committed revision 210510.
Lucas Forschler
Comment 7 2017-01-09 09:45:59 PST
(new conf file copied over in https://trac.webkit.org/changeset/210509)
Note You need to log in before you can comment on or make changes to this bug.