Summary: | Move cache coders to WTF | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||
Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cgarcia, cmarcelo, commit-queue, dbates, sam | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2017-01-08 13:52:08 PST
Created attachment 298317 [details]
patch
Attachment 298317 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/persistence/Encoder.h:94: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103: More than one command on the same line [whitespace/newline] [4]
Total errors found: 10 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 298318 [details]
patch
Attachment 298318 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/persistence/Encoder.h:94: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103: More than one command on the same line [whitespace/newline] [4]
Total errors found: 10 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 298319 [details]
patch
Attachment 298319 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/persistence/Encoder.h:94: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103: More than one command on the same line [whitespace/newline] [4]
Total errors found: 10 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 298322 [details]
patch
Attachment 298322 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/persistence/Encoder.h:94: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103: More than one command on the same line [whitespace/newline] [4]
Total errors found: 10 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 298319 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=298319&action=review > Source/WTF/wtf/persistence/Coders.cpp:35 > +#include "NetworkCacheCoders.h" > + > +#if ENABLE(NETWORK_CACHE) > + > +#include <wtf/text/CString.h> > +#include <wtf/text/WTFString.h> > + > +namespace WebKit { > +namespace NetworkCache { Are you planning to get rid of the ENABLE(NETWORK_CACHE) and namespace NetworkCache? > Source/WTF/wtf/persistence/Coders.cpp:160 > +// Store common HTTP headers as strings instead of using their value in the HTTPHeaderName enumeration > +// so that the headers stored in the cache stays valid even after HTTPHeaderName.in gets updated. > +void Coder<WebCore::HTTPHeaderMap>::encode(Encoder& encoder, const WebCore::HTTPHeaderMap& headers) Er, surely WTF cannot depend on WebCore. > Are you planning to get rid of the ENABLE(NETWORK_CACHE) and namespace
> NetworkCache?
> Er, surely WTF cannot depend on WebCore.
If you look further in the patch you see them changed appropriately. This is just how move/edit patches end up looking like.
Created attachment 298323 [details]
patch
Attachment 298323 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/persistence/Encoder.h:94: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103: More than one command on the same line [whitespace/newline] [4]
Total errors found: 10 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 298323 [details]
patch
Looks good, rs=me. What do you plan on persisting now :) ?
Probably useful to move NetworkCache::Data, NetworkCache::IOChannel, and the helpers in NetworkCacheFileSystem.h at some point. (As well as WebKit::SharedMemory I guess). > Looks good, rs=me. What do you plan on persisting now :) ?
JS related things!
Comment on attachment 298323 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=298323&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheCoders.h:43 > +namespace Persistence { It does not feel right to have code in namespace WTF inside WebKit2 > It does not feel right to have code in namespace WTF inside WebKit2
Nevertheless it is a rather common pattern for traits-like templates (search for it in WebCore).
|