Bug 166801

Summary: Add the ability to create empty contentEditable windows in MiniBrowser
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, enrica, mitz, simon.fraser, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 211243    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2017-01-07 02:44:17 PST
Add the ability to create empty contentEditable windows in MiniBrowser
Attachments
Patch (10.63 KB, patch)
2017-01-07 02:45 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (15.93 KB, patch)
2017-01-07 03:35 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (16.12 KB, patch)
2017-01-07 05:12 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-01-07 02:45:03 PST
Created attachment 298265 [details] Patch
Tim Horton
Comment 2 2017-01-07 03:35:10 PST
Created attachment 298266 [details] Patch
Tim Horton
Comment 3 2017-01-07 05:12:47 PST
Created attachment 298274 [details] Patch
Wenson Hsieh
Comment 4 2017-01-07 11:49:55 PST
Comment on attachment 298274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298274&action=review > Tools/MiniBrowser/mac/AppDelegate.m:152 > + I don't think the newline here adds much. > Tools/MiniBrowser/mac/BrowserWindowController.h:83 > +@property (nonatomic, assign, getter=isEditable) BOOL editable; Do we need an explicit @synthesize here, or implement -isEditable? It looks like the bots are not happy about it.
Tim Horton
Comment 5 2017-01-07 13:11:20 PST
Comment on attachment 298274 [details] Patch Clearing flags on attachment: 298274 Committed r210483: <http://trac.webkit.org/changeset/210483>
Tim Horton
Comment 6 2017-01-07 13:11:24 PST
All reviewed patches have been landed. Closing bug.
Tim Horton
Comment 7 2017-01-07 13:14:26 PST
Oop, you're right. I will fix it.
Tim Horton
Comment 8 2017-01-07 13:15:09 PST
(silly 32-bit)
Note You need to log in before you can comment on or make changes to this bug.