Bug 166799

Summary: Implement find-in-page in MiniBrowser
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, enrica, mitz, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2017-01-07 02:00:46 PST
Implement find-in-page in MiniBrowser
Attachments
Patch (15.88 KB, patch)
2017-01-07 02:02 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (13.48 KB, patch)
2017-01-07 02:17 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-01-07 02:02:04 PST
Created attachment 298262 [details] Patch
Tim Horton
Comment 2 2017-01-07 02:02:50 PST
Implementation mostly cribbed from WebEditingTester. It's less broken there because that app doesn't have a top content inset, but I'm not really sure how it's possible that this feature is as broken as it is.
Tim Horton
Comment 3 2017-01-07 02:17:27 PST
Created attachment 298264 [details] Patch
Andy Estes
Comment 4 2017-01-07 05:54:35 PST
Comment on attachment 298264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298264&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:681 > + [_textFindBarView setFrame:NSMakeRect(0, 0, containerView.bounds.size.width, _textFindBarView.frame.size.height)]; Should you use CGRectGet{Width,Height}() here to ensure the rect is normalized?
Tim Horton
Comment 5 2017-01-07 13:10:40 PST
Comment on attachment 298264 [details] Patch Clearing flags on attachment: 298264 Committed r210482: <http://trac.webkit.org/changeset/210482>
Tim Horton
Comment 6 2017-01-07 13:10:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.