Summary: | Implement find-in-page in MiniBrowser | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, enrica, mitz, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2017-01-07 02:00:46 PST
Created attachment 298262 [details]
Patch
Implementation mostly cribbed from WebEditingTester. It's less broken there because that app doesn't have a top content inset, but I'm not really sure how it's possible that this feature is as broken as it is. Created attachment 298264 [details]
Patch
Comment on attachment 298264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298264&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:681 > + [_textFindBarView setFrame:NSMakeRect(0, 0, containerView.bounds.size.width, _textFindBarView.frame.size.height)]; Should you use CGRectGet{Width,Height}() here to ensure the rect is normalized? Comment on attachment 298264 [details] Patch Clearing flags on attachment: 298264 Committed r210482: <http://trac.webkit.org/changeset/210482> All reviewed patches have been landed. Closing bug. |