Bug 166797

Summary: Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Darin Adler
Reported 2017-01-06 21:33:02 PST
Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
Attachments
Patch (125.13 KB, patch)
2017-01-06 21:48 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (125.18 KB, patch)
2017-01-07 09:25 PST, Darin Adler 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2017-01-06 21:48:48 PST
Created attachment 298257 [details] Patch
WebKit Commit Bot
Comment 2 2017-01-06 21:49:56 PST
Attachment 298257 [details] did not pass style-queue: ERROR: Source/WebCore/loader/EmptyClients.cpp:210: Declaration has space between type name and * in NSString *userVisibleString [whitespace/declaration] [3] ERROR: Source/WebCore/loader/EmptyClients.cpp:212: Declaration has space between type name and * in NSURL *canonicalizeURL [whitespace/declaration] [3] ERROR: Source/WebCore/loader/EmptyClients.cpp:213: Declaration has space between type name and * in NSURL *canonicalizeURLString [whitespace/declaration] [3] ERROR: Source/WebCore/loader/EmptyClients.cpp:427: Declaration has space between type name and * in NSCachedURLResponse *willCacheResponse [whitespace/declaration] [3] Total errors found: 4 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2017-01-07 09:25:37 PST
Created attachment 298279 [details] Patch
WebKit Commit Bot
Comment 4 2017-01-07 09:27:05 PST
Attachment 298279 [details] did not pass style-queue: ERROR: Source/WebCore/loader/EmptyClients.cpp:211: Declaration has space between type name and * in NSString *userVisibleString [whitespace/declaration] [3] ERROR: Source/WebCore/loader/EmptyClients.cpp:213: Declaration has space between type name and * in NSURL *canonicalizeURL [whitespace/declaration] [3] ERROR: Source/WebCore/loader/EmptyClients.cpp:214: Declaration has space between type name and * in NSURL *canonicalizeURLString [whitespace/declaration] [3] ERROR: Source/WebCore/loader/EmptyClients.cpp:428: Declaration has space between type name and * in NSCachedURLResponse *willCacheResponse [whitespace/declaration] [3] Total errors found: 4 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 5 2017-01-07 14:09:29 PST
Committed r210492: <http://trac.webkit.org/changeset/210492>
Note You need to log in before you can comment on or make changes to this bug.