Bug 166797

Summary: Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Description Darin Adler 2017-01-06 21:33:02 PST 
Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
Comment 1 Darin Adler 2017-01-06 21:48:48 PST 
Created attachment 298257 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-06 21:49:56 PST 
Attachment 298257 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyClients.cpp:210:  Declaration has space between type name and * in NSString *userVisibleString  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:212:  Declaration has space between type name and * in NSURL *canonicalizeURL  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:213:  Declaration has space between type name and * in NSURL *canonicalizeURLString  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:427:  Declaration has space between type name and * in NSCachedURLResponse *willCacheResponse  [whitespace/declaration] [3]
Total errors found: 4 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2017-01-07 09:25:37 PST 
Created attachment 298279 [details]
Patch
Comment 4 WebKit Commit Bot 2017-01-07 09:27:05 PST 
Attachment 298279 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyClients.cpp:211:  Declaration has space between type name and * in NSString *userVisibleString  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:213:  Declaration has space between type name and * in NSURL *canonicalizeURL  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:214:  Declaration has space between type name and * in NSURL *canonicalizeURLString  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:428:  Declaration has space between type name and * in NSCachedURLResponse *willCacheResponse  [whitespace/declaration] [3]
Total errors found: 4 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Darin Adler 2017-01-07 14:09:29 PST 
Committed r210492: <http://trac.webkit.org/changeset/210492>