Bug 166789

Summary: [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, joepeck, ossy, rniwa, sam, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2017-01-06 18:02:28 PST
[Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
Attachments
Patch (78.09 KB, patch)
2017-01-06 18:10 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (78.21 KB, patch)
2017-01-06 18:23 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (78.21 KB, patch)
2017-01-06 19:12 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-01-06 18:10:24 PST
Created attachment 298241 [details] Patch
Andy Estes
Comment 2 2017-01-06 18:23:00 PST
Created attachment 298243 [details] Patch
Alex Christensen
Comment 3 2017-01-06 18:25:50 PST
Comment on attachment 298243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298243&action=review > Source/WebCore/PlatformMac.cmake:747 > + bindings/cocoa/WebArchiveDumpSupport.mm bindings?
Andy Estes
Comment 4 2017-01-06 18:36:38 PST
(In reply to comment #3) > Comment on attachment 298243 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=298243&action=review > > > Source/WebCore/PlatformMac.cmake:747 > > + bindings/cocoa/WebArchiveDumpSupport.mm > > bindings? Oops! Will fix.
Andy Estes
Comment 5 2017-01-06 19:10:33 PST
Alex reviewed in person.
Andy Estes
Comment 6 2017-01-06 19:12:55 PST
Created attachment 298248 [details] Patch
WebKit Commit Bot
Comment 7 2017-01-06 19:50:03 PST
Comment on attachment 298248 [details] Patch Clearing flags on attachment: 298248 Committed r210467: <http://trac.webkit.org/changeset/210467>
WebKit Commit Bot
Comment 8 2017-01-06 19:50:07 PST
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 9 2017-01-06 20:01:28 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=298243&action=review > Source/WebCore/platform/spi/cf/CFNetworkSPI.h:186 > +CFTypeID CFURLResponseGetTypeID(); No code actually uses this. Do we expect any code to use it? > Source/WebCore/platform/spi/cf/CFNetworkSPI.h:188 > +void CFURLResponseSetExpectedContentLength(CFURLResponseRef, SInt64 length); No code actually uses this. Do we expect any code to use it?
Simon Fraser (smfr)
Comment 10 2017-01-06 22:09:52 PST
Why not put the files in Tools/TestRunnerShared/ ?
Csaba Osztrogonác
Comment 11 2017-01-06 22:22:10 PST
(In reply to comment #7) > Comment on attachment 298248 [details] > Patch > > Clearing flags on attachment: 298248 > > Committed r210467: <http://trac.webkit.org/changeset/210467> It broke the Apple Mac cmake build. https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/11115
Note You need to log in before you can comment on or make changes to this bug.